Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge test workflows to fix coverage calculation #2801

Merged
merged 1 commit into from Jun 6, 2023
Merged

Merge test workflows to fix coverage calculation #2801

merged 1 commit into from Jun 6, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jun 6, 2023 •
edited

Description

Refs #1507.

That PR requires changes in branch protection rules, hence do not merge PRs that should not be merged . But it is ready for review.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jun 6, 2023
@AlekSi AlekSi added this to the Next milestone Jun 6, 2023
@AlekSi AlekSi self-assigned this Jun 6, 2023
@AlekSi AlekSi added the do not merge PRs that should not be merged label Jun 6, 2023
@AlekSi AlekSi marked this pull request as ready for review June 6, 2023 09:23
@AlekSi AlekSi enabled auto-merge (squash) June 6, 2023 09:23
noisersup
noisersup approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@AlekSi AlekSi removed the do not merge PRs that should not be merged label Jun 6, 2023
@AlekSi AlekSi disabled auto-merge June 6, 2023 12:51
@AlekSi AlekSi merged commit 1c3df01 into FerretDB:main Jun 6, 2023
35 of 47 checks passed
@AlekSi AlekSi deleted the coveralls branch June 6, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@noisersup noisersup noisersup approved these changes

@w84thesun w84thesun Awaiting requested review from w84thesun w84thesun was automatically assigned from FerretDB/core

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlekSi @chilagrow @noisersup