Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip test that passes now #2885

Merged
merged 1 commit into from Jun 23, 2023
Merged

Unskip test that passes now #2885

merged 1 commit into from Jun 23, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jun 23, 2023

Description

All TLS parameters are now a part of URI.

Closes #1759.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

All TLS parameters are now a part of URI.

Closes FerretDB#1759.
@AlekSi AlekSi added the code/chore Code maintenance improvements label Jun 23, 2023
@AlekSi AlekSi added this to the Next milestone Jun 23, 2023
@AlekSi AlekSi requested a review from a team as a code owner June 23, 2023 07:54
@AlekSi AlekSi self-assigned this Jun 23, 2023
@AlekSi AlekSi enabled auto-merge (squash) June 23, 2023 07:54
@AlekSi AlekSi requested review from a team, w84thesun and noisersup June 23, 2023 07:54
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #2885 (6642206) into main (72df2bc) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2885      +/-   ##
==========================================
+ Coverage   63.48%   63.55%   +0.06%     
==========================================
  Files         451      451              
  Lines       23511    23512       +1     
==========================================
+ Hits        14926    14943      +17     
+ Misses       7619     7603      -16     
  Partials      966      966              
Impacted Files Coverage Δ
...ernal/handlers/common/aggregations/stages/group.go 88.60% <100.00%> (+0.07%) ⬆️

... and 3 files with indirect coverage changes

Flag Coverage Δ
integration 56.79% <100.00%> (+0.11%) ⬆️
mongodb 4.20% <0.00%> (+0.05%) ⬆️
pg 56.71% <100.00%> (+0.11%) ⬆️
shard-1 40.96% <100.00%> (+0.11%) ⬆️
shard-2 41.58% <100.00%> (+<0.01%) ⬆️
shard-3 45.19% <100.00%> (-0.01%) ⬇️
unit 24.34% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit 00aeea8 into FerretDB:main Jun 23, 2023
27 of 30 checks passed
@AlekSi AlekSi deleted the unskip-test branch June 23, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Refactor TestCommandsDiagnosticWhatsMyURI to use TLS when needed
3 participants