Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handler's metrics registration #2895

Merged
merged 3 commits into from Jun 23, 2023
Merged

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jun 23, 2023

Description

For future cursors metrics.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jun 23, 2023
@AlekSi AlekSi added this to the Next milestone Jun 23, 2023
@AlekSi AlekSi requested a review from a team as a code owner June 23, 2023 13:47
@AlekSi AlekSi self-assigned this Jun 23, 2023
@AlekSi AlekSi enabled auto-merge (squash) June 23, 2023 13:47
@AlekSi AlekSi requested review from a team, chilagrow and noisersup June 23, 2023 13:47
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #2895 (3085ae6) into main (82f54cd) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2895      +/-   ##
==========================================
- Coverage   63.60%   63.57%   -0.04%     
==========================================
  Files         451      451              
  Lines       23555    23569      +14     
==========================================
  Hits        14983    14983              
- Misses       7605     7619      +14     
  Partials      967      967              
Impacted Files Coverage Δ
internal/clientconn/conn.go 53.72% <ø> (+0.56%) ⬆️
internal/clientconn/listener.go 72.08% <0.00%> (-0.74%) ⬇️
internal/handlers/hana/hana.go 0.00% <0.00%> (ø)
internal/handlers/pg/pg.go 74.64% <0.00%> (-4.46%) ⬇️
internal/handlers/sqlite/sqlite.go 0.00% <0.00%> (ø)
internal/handlers/tigris/tigris.go 0.00% <0.00%> (ø)
Flag Coverage Δ
integration 56.82% <0.00%> (-0.04%) ⬇️
mongodb 4.19% <0.00%> (-0.01%) ⬇️
pg 56.74% <0.00%> (-0.04%) ⬇️
shard-1 41.93% <0.00%> (-0.03%) ⬇️
shard-2 45.17% <0.00%> (+0.08%) ⬆️
shard-3 40.58% <0.00%> (-0.03%) ⬇️
unit 24.27% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one question though

internal/handlers/hana/hana.go Show resolved Hide resolved
@AlekSi AlekSi disabled auto-merge June 23, 2023 15:28
@AlekSi AlekSi merged commit d2219f2 into FerretDB:main Jun 23, 2023
24 of 29 checks passed
@AlekSi AlekSi deleted the handler-metrics branch June 23, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants