Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak documentation and blog #2992

Merged
merged 11 commits into from Jul 19, 2023
Merged

Tweak documentation and blog #2992

merged 11 commits into from Jul 19, 2023

Conversation

Fashander
Copy link
Member

@Fashander Fashander commented Jul 6, 2023 •
edited

Description

Closes #2843
Closes #2847

Provided guidelines for tags and updated blog posts to match tags. Also updated documentation SEO.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@Fashander Fashander added the documentation Something user-visible is badly or not documented label Jul 6, 2023
@Fashander Fashander added this to the Next milestone Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023 •
edited

Codecov Report

Merging #2992 (956ee34) into main (3e99c38) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2992      +/-   ##
==========================================
+ Coverage   76.45%   76.49%   +0.04%     
==========================================
  Files         386      386              
  Lines       21165    21165              
==========================================
+ Hits        16181    16190       +9     
+ Misses       4056     4050       -6     
+ Partials      928      925       -3

see 4 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 72.99% <ø> (+0.04%) ⬆️
mongodb 5.54% <ø> (-0.11%) ⬇️
pg 66.29% <ø> (ø)
shard-1 54.80% <ø> (ø)
shard-2 55.14% <ø> (+0.11%) ⬆️
shard-3 57.72% <ø> (+0.04%) ⬆️
sqlite 46.76% <ø> (+0.04%) ⬆️
unit 24.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Fashander
Copy link
Member Author

@AlekSi PTAL

@AlekSi
Copy link
Member

AlekSi commented Jul 10, 2023

Closes #2843 #2847

That will not work, it should be one "Closes #number" per line. "Conform PR" action will also fail.

@Fashander Fashander requested a review from AlekSi July 11, 2023 13:48
AlekSi
AlekSi reviewed Jul 11, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Conform PR" check fails. Some checked checklist items are not actually done.

@Fashander Fashander enabled auto-merge (squash) July 11, 2023 13:58
@Fashander
Copy link
Member Author

Fashander commented Jul 11, 2023 •
edited

@AlekSi Conform PR cites Sprint field and auto-merge. I've set the Milestone and auto-merge, but I'm unable to set project/sprint fields.

@AlekSi
Copy link
Member

AlekSi commented Jul 11, 2023

@Fashander Please try now

@Fashander Fashander requested a review from AlekSi July 11, 2023 14:05
@AlekSi AlekSi added trust PRs that can access Actions secrets blog/marketing Marketing (and releases) blog posts labels Jul 13, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2023

Marketing blog posts should be reviewed by @ptrfarkas and @AlekSi.

@AlekSi AlekSi disabled auto-merge July 13, 2023 14:41
@AlekSi AlekSi enabled auto-merge (squash) July 13, 2023 14:41
AlekSi
AlekSi reviewed Jul 13, 2023
View reviewed changes
website/blog/2022-05-16-using-cla-assistant-with-ferretdb.md Outdated Show resolved Hide resolved
website/blog/2022-05-16-using-cla-assistant-with-ferretdb.md Outdated Show resolved Hide resolved
website/docs/contributing/writing-guide.md Outdated Show resolved Hide resolved
website/docs/main.md Outdated Show resolved Hide resolved
website/docs/understanding-ferretdb.md Outdated Show resolved Hide resolved
@Fashander Fashander requested a review from AlekSi July 14, 2023 01:03
@AlekSi AlekSi modified the milestones: v1.6.0, Next Jul 17, 2023
@Fashander
Copy link
Member Author

@AlekSi PTAL

@Fashander Fashander requested a review from AlekSi July 19, 2023 00:04
@AlekSi AlekSi disabled auto-merge July 19, 2023 10:11
@AlekSi AlekSi merged commit c9ec84a into FerretDB:main Jul 19, 2023
25 of 31 checks passed
@Fashander Fashander deleted the seo-update branch December 4, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

Assignees

@Fashander Fashander

Labels
blog/marketing Marketing (and releases) blog posts documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets
Projects
Current Engineering
Archived in project
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

Add guidelines for keywords and tags Improve SEO for documentation and blog
2 participants
@Fashander @AlekSi