Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore lsid field in all commands #3010

Merged
merged 3 commits into from Jul 10, 2023
Merged

Conversation

b1ron
Copy link
Contributor

@b1ron b1ron commented Jul 7, 2023

Description

Fixes FailedToParse errors seen in dance.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@b1ron b1ron added the code/bug Some user-visible feature works incorrectly label Jul 7, 2023
@b1ron b1ron self-assigned this Jul 7, 2023
@b1ron b1ron changed the title Ignore lsid field in all handlers Ignore lsid field in all commands Jul 7, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #3010 (a4901a6) into main (c8e3fd1) will decrease coverage by 2.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3010      +/-   ##
==========================================
- Coverage   76.15%   74.14%   -2.01%     
==========================================
  Files         385      385              
  Lines       21070    21070              
==========================================
- Hits        16046    15623     -423     
- Misses       4094     4490     +396     
- Partials      930      957      +27     
Impacted Files Coverage Δ
internal/handlers/common/distinct.go 84.28% <ø> (ø)
internal/handlers/common/findandmodify.go 73.44% <ø> (-3.39%) ⬇️
internal/handlers/common/update_params.go 100.00% <ø> (ø)

... and 24 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 70.53% <ø> (-2.13%) ⬇️
mongodb 5.33% <ø> (ø)
pg 60.71% <ø> (-5.50%) ⬇️
shard-1 55.21% <ø> (-0.02%) ⬇️
shard-2 36.45% <ø> (-18.88%) ⬇️
shard-3 56.63% <ø> (ø)
sqlite 45.86% <ø> (ø)
unit 24.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@b1ron b1ron marked this pull request as ready for review July 7, 2023 12:16
@b1ron b1ron requested a review from a team as a code owner July 7, 2023 12:16
@b1ron b1ron enabled auto-merge (squash) July 7, 2023 12:17
@AlekSi AlekSi added this to the Next milestone Jul 10, 2023
@b1ron b1ron merged commit c35473a into FerretDB:main Jul 10, 2023
23 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/bug Some user-visible feature works incorrectly
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants