Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update database naming restrictions #3042

Merged
merged 2 commits into from Jul 13, 2023
Merged

Update database naming restrictions #3042

merged 2 commits into from Jul 13, 2023

Conversation

b1ron
Copy link
Contributor

@b1ron b1ron commented Jul 12, 2023

Description

We now allow database names to start with numbers.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@b1ron b1ron added the documentation Something user-visible is badly or not documented label Jul 12, 2023
@b1ron b1ron self-assigned this Jul 12, 2023
@b1ron b1ron requested a review from Fashander July 12, 2023 16:54
@b1ron b1ron marked this pull request as ready for review July 12, 2023 16:54
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #3042 (291d353) into main (4bab468) will decrease coverage by 2.16%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3042      +/-   ##
==========================================
- Coverage   76.42%   74.26%   -2.16%     
==========================================
  Files         386      386              
  Lines       21120    21120              
==========================================
- Hits        16140    15684     -456     
- Misses       4058     4481     +423     
- Partials      922      955      +33     

see 26 files with indirect coverage changes

Flag Coverage Δ
integration 70.68% <ø> (-2.25%) ⬇️
mongodb 5.41% <ø> (ø)
pg 60.43% <ø> (-5.90%) ⬇️
shard-1 54.20% <ø> (-0.02%) ⬇️
shard-2 36.87% <ø> (-18.85%) ⬇️
shard-3 57.10% <ø> (ø)
sqlite 46.53% <ø> (ø)
unit 24.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi enabled auto-merge (squash) July 13, 2023 05:26
@AlekSi AlekSi requested a review from noisersup July 13, 2023 05:26
@AlekSi AlekSi added this to the Next milestone Jul 13, 2023
@AlekSi AlekSi merged commit 1352a47 into FerretDB:main Jul 13, 2023
23 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Something user-visible is badly or not documented
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants