Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to change SQLite URI in tests #3092

Merged
merged 1 commit into from Jul 20, 2023
Merged

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 20, 2023

Description

Useful for task env-data.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jul 20, 2023
@AlekSi AlekSi added this to the Next milestone Jul 20, 2023
@AlekSi AlekSi self-assigned this Jul 20, 2023
@AlekSi AlekSi marked this pull request as ready for review July 20, 2023 15:54
@AlekSi AlekSi requested a review from a team as a code owner July 20, 2023 15:54
@AlekSi AlekSi enabled auto-merge (squash) July 20, 2023 15:54
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #3092 (edb6563) into main (eb5addc) will increase coverage by 0.08%.
The diff coverage is 86.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3092      +/-   ##
==========================================
+ Coverage   76.55%   76.63%   +0.08%     
==========================================
  Files         388      389       +1     
  Lines       21297    21307      +10     
==========================================
+ Hits        16303    16328      +25     
+ Misses       4065     4053      -12     
+ Partials      929      926       -3     
Impacted Files Coverage Δ
integration/setup/setup.go 79.77% <ø> (ø)
internal/backends/sqlite/metadata/pool/db.go 67.74% <ø> (ø)
integration/setup/startup.go 67.81% <75.00%> (-0.94%) ⬇️
integration/setup/listener.go 72.32% <80.00%> (-0.46%) ⬇️
internal/backends/sqlite/metadata/pool/uri.go 90.62% <90.62%> (ø)
internal/backends/sqlite/metadata/pool/pool.go 84.76% <100.00%> (-1.17%) ⬇️

... and 6 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 73.16% <50.00%> (+0.08%) ⬆️
mongodb 5.46% <0.00%> (-0.03%) ⬇️
pg 66.40% <6.00%> (-0.07%) ⬇️
shard-1 57.02% <50.00%> (+0.09%) ⬆️
shard-2 55.10% <50.00%> (+<0.01%) ⬆️
shard-3 57.14% <50.00%> (-0.02%) ⬇️
sqlite 46.51% <48.00%> (+0.09%) ⬆️
unit 24.08% <90.90%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi requested review from a team, quasilyte and noisersup July 20, 2023 15:55
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks useful!

@AlekSi AlekSi disabled auto-merge July 20, 2023 16:30
@AlekSi AlekSi merged commit 110cfa0 into FerretDB:main Jul 20, 2023
27 of 34 checks passed
@AlekSi AlekSi deleted the sqlite-uri branch July 20, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants