Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the writing guide accessible but unlisted #3221

Merged
merged 1 commit into from Aug 17, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Aug 17, 2023

Description

It will be hidden in the sidebar but available by direct URL.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

It will be hidden in the sidebar but available by direct URL.
@AlekSi AlekSi added documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets labels Aug 17, 2023
@AlekSi AlekSi added this to the Next milestone Aug 17, 2023
@AlekSi AlekSi self-assigned this Aug 17, 2023
@AlekSi AlekSi requested a review from ptrfarkas as a code owner August 17, 2023 11:31
@AlekSi AlekSi enabled auto-merge (squash) August 17, 2023 11:31
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #3221 (b8e6484) into main (31078f4) will decrease coverage by 27.23%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3221       +/-   ##
===========================================
- Coverage   75.46%   48.23%   -27.23%     
===========================================
  Files         396      396               
  Lines       22210    22210               
===========================================
- Hits        16761    10714     -6047     
- Misses       4464    10685     +6221     
+ Partials      985      811      -174     

see 127 files with indirect coverage changes

Flag Coverage Δ
integration 39.01% <ø> (-32.86%) ⬇️
mongodb 5.30% <ø> (ø)
pg ?
shard-1 32.58% <ø> (-23.34%) ⬇️
shard-2 31.86% <ø> (-23.43%) ⬇️
shard-3 27.37% <ø> (-28.37%) ⬇️
sqlite 38.73% <ø> (+1.08%) ⬆️
unit 24.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AlekSi AlekSi disabled auto-merge August 17, 2023 11:45
@AlekSi AlekSi merged commit a35f4e1 into FerretDB:main Aug 17, 2023
23 of 30 checks passed
@AlekSi AlekSi deleted the writing-guide branch August 17, 2023 11:45
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants