Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info about command metrics for diff-proxy mode #3226

Closed
wants to merge 4 commits into from

Conversation

b1ron
Copy link
Contributor

@b1ron b1ron commented Aug 21, 2023

Description

Closes #3242.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@b1ron b1ron self-assigned this Aug 21, 2023
@b1ron b1ron added the documentation Something user-visible is badly or not documented label Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #3226 (ce39d91) into main (36ce153) will decrease coverage by 0.14%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3226      +/-   ##
==========================================
- Coverage   75.76%   75.62%   -0.14%     
==========================================
  Files         396      396              
  Lines       22196    22219      +23     
==========================================
- Hits        16816    16803      -13     
- Misses       4409     4444      +35     
- Partials      971      972       +1     

see 7 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 72.07% <ø> (-0.10%) ⬇️
mongodb 5.29% <ø> (-0.01%) ⬇️
pg 65.11% <ø> (-0.10%) ⬇️
shard-1 56.83% <ø> (-0.05%) ⬇️
shard-2 55.47% <ø> (-0.08%) ⬇️
shard-3 56.18% <ø> (-0.05%) ⬇️
sqlite 47.33% <ø> (-0.05%) ⬇️
unit 24.54% <ø> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@b1ron b1ron marked this pull request as ready for review August 21, 2023 13:43
@b1ron b1ron requested a review from AlekSi as a code owner August 21, 2023 13:43
@b1ron b1ron requested review from a team, rumyantseva, chilagrow and noisersup August 21, 2023 13:43
@b1ron b1ron enabled auto-merge (squash) August 21, 2023 13:43
@AlekSi AlekSi added this to the Next milestone Aug 23, 2023
@AlekSi AlekSi disabled auto-merge August 23, 2023 11:23
@AlekSi AlekSi enabled auto-merge (squash) August 23, 2023 11:23
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do what #3242 says now

@b1ron
Copy link
Contributor Author

b1ron commented Aug 23, 2023

Closing because work is redirected to #3242.

@b1ron b1ron closed this Aug 23, 2023
auto-merge was automatically disabled August 23, 2023 12:21

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Something user-visible is badly or not documented
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Document compatibility checking process/tools
2 participants