Check that linked issues are open

[KrishnaSindhur]

Description

Closes #2733.

Readiness checklist

• I added/updated unit tests (and they pass).
• I added/updated integration/compatibility tests (and they pass).
• I added/updated comments and checked rendering.
• I made spot refactorings.
• I updated user documentation.
• I ran task all, and it passed.
• I ensured that PR title is good enough for the changelog.
• (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
• I marked all done items in this checklist.

[codecov]

Codecov Report

Merging #3277 (f35022e) into main (5034b84) will decrease coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3277      +/-   ##
==========================================
- Coverage   61.65%   61.51%   -0.14%     
==========================================
  Files         426      426              
  Lines       27399    27399              
==========================================
- Hits        16892    16855      -37     
- Misses       9506     9540      +34     
- Partials     1001     1004       +3     

see 10 files with indirect coverage changes

Flag	Coverage Δ
filter-true	58.06% <ø> (-0.13%)	⬇️
hana-1	?
integration	58.06% <ø> (-0.13%)	⬇️
mongodb-1	4.50% <ø> (ø)
postgresql-1	41.26% <ø> (+0.03%)	⬆️
postgresql-2	41.79% <ø> (ø)
postgresql-3	40.10% <ø> (+0.04%)	⬆️
sort-false	58.06% <ø> (-0.13%)	⬇️
sqlite-1	41.07% <ø> (-0.10%)	⬇️
sqlite-2	41.97% <ø> (ø)
sqlite-3	40.07% <ø> (-0.03%)	⬇️
unit	22.40% <ø> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[AlekSi]

Could you please add tests to testdata.go with an open and closed issue? If implemented correctly, they will show that this code doesn't detect closed issues correctly

[KrishnaSindhur]

@AlekSi I realised now there in no clear way to find issue open or closed by issue url like we used in our test, is there any better way?

[AlekSi]

I think we could use the GitHub API via https://github.com/google/go-github. We have some examples there: https://github.com/FerretDB/github-actions/blob/main/conform-pr/main.go

[AlekSi]

@KrishnaSindhur, any news? Anything we could help you with?

[KrishnaSindhur]

Will raise a PR shortly!!

[KrishnaSindhur]

@AlekSi this PR is like draft just want to know how to test locally? github token is required to test it locally and some repo information please check!!

[AlekSi]

Tests fail because they are getting URLs like https://api.github.com/repos/owner/https://github.com/FerretDB/FerretDB/issues/2733. They don't look valid :)

[KrishnaSindhur]

what we should do if we have below URL? should we ignore or catch it?
https://api.github.com/repos/owner/https://github.com/FerretDB/FerretDB/issues/2733

[AlekSi]

we have to remove // want

That would be the equivalent of removing a test, and we want to keep that test. Let's find some other solution. For example, we could remove // want … part if the file name is testdata.go.

Let's also gather all URLs first, remove duplicates, and then check them. Right now we check the same issue multiple times, quickly running over a rate limit for unauthenticated requests.

[AlekSi]

#3277 (comment)

[KrishnaSindhur]

@AlekSi should i make change to remove? this should be check in todo statement to check file name something and then avoid // want ..

// want … part if the file name is testdata.go.

so then how do we check for duplicate issue without a api hit?

[AlekSi]

so then how do we check for duplicate issue without a api hit?

By collecting already checked URLs and not checking the same URL twice

[AlekSi]

Thank you for all the hard work!

[KrishnaSindhur]

hey sorry i was occupied with some other things could not spend time last 2 weeks
@AlekSi

[AlekSi]

No worries! :)