Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transactions to fsql #3278

Merged
merged 1 commit into from Aug 30, 2023
Merged

Add transactions to fsql #3278

merged 1 commit into from Aug 30, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Aug 29, 2023

Description

They will be covered by integration tests in the next PR.

Closes #2750.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Aug 29, 2023
@AlekSi AlekSi added this to the Next milestone Aug 29, 2023
@AlekSi AlekSi self-assigned this Aug 29, 2023
@AlekSi AlekSi requested a review from a team as a code owner August 29, 2023 18:39
@AlekSi AlekSi enabled auto-merge (squash) August 29, 2023 18:39
@AlekSi AlekSi requested review from a team and noisersup August 29, 2023 18:39
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #3278 (9ffa80a) into main (2e847f0) will decrease coverage by 0.31%.
The diff coverage is 1.83%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3278      +/-   ##
==========================================
- Coverage   75.24%   74.93%   -0.31%     
==========================================
  Files         399      400       +1     
  Lines       22681    22788     +107     
==========================================
+ Hits        17066    17076      +10     
- Misses       4625     4725     +100     
+ Partials      990      987       -3     
Files Changed Coverage Δ
internal/util/fsql/tx.go 0.00% <0.00%> (ø)
internal/util/fsql/db.go 60.00% <2.50%> (-35.46%) ⬇️
internal/util/fsql/rows.go 100.00% <100.00%> (+14.28%) ⬆️

... and 2 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 71.41% <1.83%> (-0.30%) ⬇️
mongodb 5.16% <0.00%> (-0.03%) ⬇️
pg 63.48% <0.00%> (-0.31%) ⬇️
shard-1 55.70% <1.83%> (-0.33%) ⬇️
shard-2 54.39% <1.83%> (-0.26%) ⬇️
shard-3 55.57% <1.83%> (-0.27%) ⬇️
sqlite 54.06% <1.83%> (-0.22%) ⬇️
unit 24.11% <1.83%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi mentioned this pull request Aug 29, 2023
9 tasks
Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@AlekSi AlekSi merged commit e9f6e90 into FerretDB:main Aug 30, 2023
27 of 29 checks passed
@AlekSi AlekSi deleted the fsql-transactions branch August 30, 2023 01:34
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support ordered inserts for SQLite
3 participants