Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak MongoDB initialization process #3307

Merged
merged 6 commits into from Sep 6, 2023
Merged

Tweak MongoDB initialization process #3307

merged 6 commits into from Sep 6, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Sep 5, 2023

Description

And add TODOs.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi self-assigned this Sep 5, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Sep 5, 2023
@AlekSi AlekSi added this to the Next milestone Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #3307 (c965516) into main (1262111) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3307      +/-   ##
==========================================
- Coverage   75.22%   75.16%   -0.06%     
==========================================
  Files         400      400              
  Lines       23374    23374              
==========================================
- Hits        17582    17569      -13     
- Misses       4765     4773       +8     
- Partials     1027     1032       +5     
Files Changed Coverage
internal/util/ctxutil/ctxutil.go 100.00%
Flag Coverage Δ
hana ?
integration 71.76% <100.00%> (-0.05%) ⬇️
mongodb 5.05% <0.00%> (+<0.01%) ⬆️
pg 61.96% <100.00%> (+<0.01%) ⬆️
shard-1 56.58% <100.00%> (ø)
shard-2 55.60% <100.00%> (-0.05%) ⬇️
shard-3 54.34% <100.00%> (ø)
sqlite 55.39% <0.00%> (-0.06%) ⬇️
unit 24.77% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi changed the title Enable OpLog in MongoDB Tweak MongoDB initialization process Sep 5, 2023
@AlekSi AlekSi marked this pull request as ready for review September 5, 2023 17:31
@AlekSi AlekSi requested a review from a team as a code owner September 5, 2023 17:31
@AlekSi AlekSi enabled auto-merge (squash) September 5, 2023 17:31
@AlekSi AlekSi requested review from a team and noisersup September 5, 2023 17:31
Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlekSi AlekSi disabled auto-merge September 6, 2023 05:00
@AlekSi AlekSi merged commit 7fe8ece into FerretDB:main Sep 6, 2023
28 of 29 checks passed
@AlekSi AlekSi deleted the oplog branch September 6, 2023 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants