Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tests for enable setFreeMonitoring for MongoDB #3318

Merged

Conversation

chilagrow
Copy link
Contributor

@chilagrow chilagrow commented Sep 6, 2023

Description

Closes #{issue_number}.

Free monitoring cannot be enabled anymore https://www.mongodb.com/docs/manual/reference/command/setFreeMonitoring/

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Sep 6, 2023
@chilagrow chilagrow added this to the Next milestone Sep 6, 2023
@chilagrow chilagrow self-assigned this Sep 6, 2023
@chilagrow chilagrow requested review from a team, rumyantseva and noisersup September 6, 2023 09:17
@chilagrow chilagrow marked this pull request as ready for review September 6, 2023 09:17
@chilagrow chilagrow requested a review from a team as a code owner September 6, 2023 09:17
@chilagrow chilagrow enabled auto-merge (squash) September 6, 2023 09:17
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #3318 (2d58431) into main (302ef22) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3318      +/-   ##
==========================================
- Coverage   75.26%   75.22%   -0.04%     
==========================================
  Files         400      400              
  Lines       23559    23559              
==========================================
- Hits        17731    17722       -9     
- Misses       4797     4805       +8     
- Partials     1031     1032       +1     
Flag Coverage Δ
hana ?
integration 71.83% <ø> (-0.06%) ⬇️
mongodb 5.01% <ø> (-0.02%) ⬇️
pg 62.11% <ø> (-0.01%) ⬇️
shard-1 56.09% <ø> (ø)
shard-2 54.79% <ø> (-0.04%) ⬇️
shard-3 54.89% <ø> (ø)
sqlite 55.60% <ø> (-0.06%) ⬇️
unit 24.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@chilagrow chilagrow merged commit 128fa84 into FerretDB:main Sep 6, 2023
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants