Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need to close conninfo #3376

Merged
merged 1 commit into from Sep 19, 2023
Merged

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Sep 19, 2023

Description

It is a simple object now.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

It is a simple object now.
@AlekSi AlekSi added the code/chore Code maintenance improvements label Sep 19, 2023
@AlekSi AlekSi added this to the Next milestone Sep 19, 2023
@AlekSi AlekSi requested a review from a team as a code owner September 19, 2023 07:31
@AlekSi AlekSi self-assigned this Sep 19, 2023
@AlekSi AlekSi enabled auto-merge (squash) September 19, 2023 07:31
@AlekSi AlekSi requested review from a team and noisersup September 19, 2023 07:31
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #3376 (00f650d) into main (9f8f895) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3376      +/-   ##
==========================================
- Coverage   74.20%   74.11%   -0.10%     
==========================================
  Files         413      413              
  Lines       25321    25312       -9     
==========================================
- Hits        18789    18759      -30     
- Misses       5440     5456      +16     
- Partials     1092     1097       +5     
Files Changed Coverage
internal/clientconn/conn.go 100.00%
internal/clientconn/conninfo/conn_info.go 100.00%
Flag Coverage Δ
hana-1 ?
hana-2 ?
hana-3 ?
integration 71.05% <100.00%> (-0.11%) ⬇️
mongodb-1 4.72% <0.00%> (+<0.01%) ⬆️
pg-1 43.74% <100.00%> (-0.07%) ⬇️
pg-2 43.51% <100.00%> (-0.03%) ⬇️
pg-3 44.06% <100.00%> (-0.05%) ⬇️
sqlite-1 42.63% <100.00%> (-0.08%) ⬇️
sqlite-2 42.08% <100.00%> (-0.03%) ⬇️
sqlite-3 42.99% <100.00%> (-0.07%) ⬇️
unit 23.27% <20.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi merged commit c844bcc into FerretDB:main Sep 19, 2023
28 of 29 checks passed
@AlekSi AlekSi deleted the remove-conninfo-close branch September 19, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants