Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder codebase in SQLite registry #3382

Merged
merged 2 commits into from Sep 21, 2023

Conversation

chilagrow
Copy link
Contributor

@chilagrow chilagrow commented Sep 20, 2023

Description

Closes #{issue_number}.

Switch the order of code so that sqlite registry has below order

func ExportedAFunc() ...

func unexportedAFunc() ...

func ExportedBFunc() ...

func unexportedbFunc() ..

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Sep 20, 2023
@chilagrow chilagrow added this to the Next milestone Sep 20, 2023
@chilagrow chilagrow self-assigned this Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #3382 (4b08bd5) into main (f98a6f6) will decrease coverage by 6.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3382      +/-   ##
==========================================
- Coverage   74.25%   68.04%   -6.21%     
==========================================
  Files         414      414              
  Lines       25356    25356              
==========================================
- Hits        18827    17254    -1573     
- Misses       5441     6927    +1486     
- Partials     1088     1175      +87     
Files Changed Coverage
internal/backends/sqlite/metadata/registry.go 100.00%
Flag Coverage Δ
hana-1 ?
hana-2 ?
hana-3 ?
integration 64.37% <72.72%> (-6.84%) ⬇️
mongodb-1 4.76% <0.00%> (ø)
pg-1 43.85% <0.00%> (ø)
pg-2 43.58% <0.00%> (ø)
pg-3 ?
pushdown-false 50.67% <72.72%> (-5.73%) ⬇️
pushdown-true 64.37% <72.72%> (-6.84%) ⬇️
sqlite-1 42.71% <72.72%> (-0.10%) ⬇️
sqlite-2 42.21% <72.72%> (-0.01%) ⬇️
sqlite-3 ?
unit 23.39% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow marked this pull request as ready for review September 21, 2023 02:18
@chilagrow chilagrow enabled auto-merge (squash) September 21, 2023 02:18
@chilagrow chilagrow requested review from a team, rumyantseva and noisersup September 21, 2023 02:18
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! More consistency and easier to navigate :)

@chilagrow chilagrow merged commit 0496e21 into FerretDB:main Sep 21, 2023
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants