Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Republish Hacktobest blog post #3429

Merged
merged 11 commits into from Sep 28, 2023
Merged

Republish Hacktobest blog post #3429

merged 11 commits into from Sep 28, 2023

Conversation

Fashander
Copy link
Member

Description

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@Fashander Fashander added the blog/marketing Marketing (and releases) blog posts label Sep 25, 2023
@Fashander Fashander added this to the Next milestone Sep 25, 2023
@mergify mergify bot requested review from AlekSi and ptrfarkas September 25, 2023 14:29
@mergify
Copy link
Contributor

mergify bot commented Sep 25, 2023

Marketing blog posts should be reviewed by @ptrfarkas and @AlekSi.

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #3429 (09a81bc) into main (4db6de2) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3429      +/-   ##
==========================================
+ Coverage   75.37%   75.41%   +0.04%     
==========================================
  Files         422      422              
  Lines       26263    26263              
==========================================
+ Hits        19795    19807      +12     
+ Misses       5324     5316       -8     
+ Partials     1144     1140       -4     

see 3 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.05% <ø> (+0.02%) ⬆️
hana-1 2.99% <ø> (ø)
integration 72.05% <ø> (+0.02%) ⬆️
mongodb-1 4.65% <ø> (ø)
pg-1 41.40% <ø> (+0.03%) ⬆️
pg-2 42.48% <ø> (ø)
pg-3 43.76% <ø> (ø)
postgresql-1 ∅ <ø> (∅)
postgresql-2 40.13% <ø> (-0.01%) ⬇️
postgresql-3 41.51% <ø> (ø)
sort-false 72.05% <ø> (+0.02%) ⬆️
sqlite-1 40.39% <ø> (ø)
sqlite-2 41.67% <ø> (ø)
sqlite-3 43.26% <ø> (ø)
unit 24.54% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd check the info about t-shirts :)

Also, I think now there are more rules about issues now - https://hacktoberfest.com/participation/#pr-mr-details. E.g. the repo should have a particular topic/label. It's on our side to check that we have all these necessary things.

The rest looks good to me!

@Fashander Fashander marked this pull request as ready for review September 26, 2023 00:24
@Fashander Fashander enabled auto-merge (squash) September 26, 2023 00:24
@Fashander Fashander added the trust PRs that can access Actions secrets label Sep 26, 2023
rumyantseva
rumyantseva previously approved these changes Sep 26, 2023
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now!

Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also bump the date to tomorrow

Do you see a typo, a mistake, or something that doesn't look clear?

We have several good first issues that you can start with.
For example, you could implement the [`$first` accumulator](https://github.com/FerretDB/FerretDB/issues/2128), [improve embedded package documentation](https://github.com/FerretDB/FerretDB/issues/2326), or [fix linter issues](https://github.com/FerretDB/FerretDB/issues/2733).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last one is already taken


We have several good first issues that you can start with.
For example, you could implement the [`$first` accumulator](https://github.com/FerretDB/FerretDB/issues/2128), [improve embedded package documentation](https://github.com/FerretDB/FerretDB/issues/2326), or [fix linter issues](https://github.com/FerretDB/FerretDB/issues/2733).
You could also try your hands at [updating glossary list with more details](https://github.com/FerretDB/FerretDB/issues/3427), [update aggregation section to cover `$unset` and `$project` commands](https://github.com/FerretDB/FerretDB/issues/3428), and more.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both are taken

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That changes the image of the old blog post as well. I'm not sure this is ok

@@ -25,24 +25,25 @@ This is how the members of the open source community encourage new tech enthusia

[Hacktoberfest](https://hacktoberfest.com/) is an annual online event celebrating the open source movement.
This year, registration starts on September 26.
To participate, you need to send at least four open-sourced pull requests on GitHub or Gitlab between October 1st and October 31st, and those pull requests need to be accepted by the repository owners.
To participate, you need to send at least four open-sourced pull requests on GitHub or Gitlab between October 1st and October 31st, for projects that indicate they are looking for Hacktoberfest contributions (`hacktoberfest` labels), and those pull requests need to be accepted by the repository owners.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dates are different. hacktoberfest is a repository topic, not a label. Repositories have topics, issues have labels.

@@ -71,7 +72,7 @@ It's essential to find some "low-hanging fruit" that will give you inspiration f
On GitHub, it might make sense to look for "good-first-issue" labels.
Usually, issues that are marked with such a label don't require special knowledge about the project.

There is one more tradition here, in October, some open source projects mark their issues with the "[hacktoberfest](https://github.com/search?q=label%3Ahacktoberfest&type=issues)" label, and such issues are often suitable for first-time contributors.
There is one more tradition here, in October, some open source projects mark their issues with the [`hacktoberfest`](https://github.com/search?q=label%3Ahacktoberfest&type=issues) label, and such issues are often suitable for first-time contributors.

At FerretDB, we are preparing for Hacktoberfest too!
So, if you are looking for something to contribute to, take a look at the good first issues in our [FerretDB](https://github.com/FerretDB/FerretDB/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) and [github-actions](https://github.com/FerretDB/github-actions/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) repositories.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No github-actions this year

author: Elena Grahovac
description: Contributing to open source might seem daunting, but you can start your tech journey during Hacktoberfest 2022.
description: Contributing to open source might seem daunting, but you can start your tech journey during Hacktoberfest 2023.
image: /img/blog/hacktoberfest.jpg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the old logo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably better we update the image, and make it similar to other recent blog posts.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why we insist on using the single file for two different images, but I'm sure it is not a good idea. File names are free. We can have hacktoberfest.jpg and something like hacktoberfest-2023.jpg in the same directory

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the same note – both the URL and file name mention 2022

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL is okay since we are republishing; we don't want to change the URL. Otherwise, the current link won't be reachable

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why we are making it so needlessly complicated. Can we just create a new post instead of "republishing" with wrong logo and different years in the URL and text?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would mean creating a new blog post entirely from scratch without plagiarizing the previous one, even when 80% of the content will remain the same. This way, we are just updating the old blog posts with new information rather than rewriting the entire thing all over again. It's a normal process with old posts that just require a bit of new info.

@AlekSi AlekSi merged commit 7efc265 into FerretDB:main Sep 28, 2023
24 of 31 checks passed
@Fashander Fashander deleted the hacktoberfest branch December 4, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blog/marketing Marketing (and releases) blog posts trust PRs that can access Actions secrets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants