Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running a subset of tests #3479

Merged
merged 1 commit into from Oct 2, 2023
Merged

Fix running a subset of tests #3479

merged 1 commit into from Oct 2, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 2, 2023

Description

The logic condition was wrong, and the error was hidden.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi self-assigned this Oct 2, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 2, 2023
@AlekSi AlekSi added this to the Next milestone Oct 2, 2023
@AlekSi AlekSi marked this pull request as ready for review October 2, 2023 09:03
@AlekSi AlekSi requested a review from a team as a code owner October 2, 2023 09:03
@AlekSi AlekSi requested review from rumyantseva, chilagrow, a team and noisersup October 2, 2023 09:03
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #3479 (ddd6c27) into main (85626b8) will decrease coverage by 69.67%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #3479       +/-   ##
==========================================
- Coverage   74.30%   4.63%   -69.67%     
==========================================
  Files         422     416        -6     
  Lines       26374   26058      -316     
==========================================
- Hits        19597    1208    -18389     
- Misses       5624   24768    +19144     
+ Partials     1153      82     -1071     

see 326 files with indirect coverage changes

Flag Coverage Δ
filter-true 4.63% <ø> (-64.68%) ⬇️
hana-1 ?
integration 4.63% <ø> (-64.68%) ⬇️
mongodb-1 4.63% <ø> (ø)
pg-1 ?
pg-2 ?
pg-3 ?
postgresql-1 ?
postgresql-2 ?
postgresql-3 ?
sort-false 4.63% <ø> (-64.68%) ⬇️
sqlite-1 ?
sqlite-2 ?
sqlite-3 ?
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 👍

@AlekSi AlekSi merged commit 2c8d2b6 into FerretDB:main Oct 2, 2023
25 of 32 checks passed
@AlekSi AlekSi deleted the fix-tests-run branch October 2, 2023 09:08
princejha95 pushed a commit to princejha95/FerretDB that referenced this pull request Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants