Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve definitions for aggregation stages #3499

Merged
merged 5 commits into from Oct 6, 2023

Conversation

Fashander
Copy link
Member

@Fashander Fashander commented Oct 4, 2023

Description

Closes #3428

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@Fashander Fashander added the documentation Something user-visible is badly or not documented label Oct 4, 2023
@Fashander Fashander added this to the Next milestone Oct 4, 2023
@Fashander Fashander requested a review from AlekSi as a code owner October 4, 2023 14:41
@Fashander Fashander self-assigned this Oct 4, 2023
@Fashander Fashander enabled auto-merge (squash) October 4, 2023 14:42
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #3499 (aa5a79e) into main (e5e2485) will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3499      +/-   ##
==========================================
- Coverage   74.31%   73.96%   -0.36%     
==========================================
  Files         426      426              
  Lines       26858    26858              
==========================================
- Hits        19960    19865      -95     
- Misses       5738     5815      +77     
- Partials     1160     1178      +18     

see 11 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 68.10% <ø> (-0.43%) ⬇️
hana-1 2.93% <ø> (ø)
integration 68.10% <ø> (-0.48%) ⬇️
mongodb-1 4.57% <ø> (ø)
pg-1 39.32% <ø> (-0.47%) ⬇️
pg-2 42.49% <ø> (-0.45%) ⬇️
pg-3 42.90% <ø> (-0.62%) ⬇️
postgresql-1 ∅ <ø> (∅)
postgresql-2 ∅ <ø> (∅)
postgresql-3 ∅ <ø> (∅)
sort-false 68.10% <ø> (-0.07%) ⬇️
sort-true ?
sqlite-1 38.40% <ø> (-0.10%) ⬇️
sqlite-2 41.55% <ø> (-0.11%) ⬇️
sqlite-3 42.42% <ø> (-0.03%) ⬇️
unit 25.59% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Fashander Fashander added the trust PRs that can access Actions secrets label Oct 4, 2023
@Fashander Fashander merged commit e5b58ea into FerretDB:main Oct 6, 2023
29 of 33 checks passed
@Fashander Fashander deleted the improve-definition branch December 4, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add $project and $unset to documentation
3 participants