Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement sort pushdown for PostgreSQL #3504

Merged
merged 31 commits into from Oct 17, 2023
Merged

Implement sort pushdown for PostgreSQL #3504

merged 31 commits into from Oct 17, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Oct 5, 2023 •
edited

Description

Closes #3415.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@noisersup noisersup self-assigned this Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023 •
edited

Codecov Report

Merging #3504 (f20e315) into main (3d3eb82) will decrease coverage by 0.55%.
The diff coverage is 28.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3504      +/-   ##
==========================================
- Coverage   61.67%   61.13%   -0.55%     
==========================================
  Files         426      426              
  Lines       27399    27474      +75     
==========================================
- Hits        16899    16796     -103     
- Misses       9501     9661     +160     
- Partials      999     1017      +18
Files Coverage Δ
internal/backends/collection.go 92.30% <ø> (ø)
internal/backends/postgresql/query.go 78.52% <64.10%> (-4.09%) ⬇️
internal/handlers/sqlite/msg_explain.go 56.25% <6.66%> (-11.94%) ⬇️
internal/handlers/sqlite/msg_find.go 72.09% <0.00%> (-8.78%) ⬇️
internal/backends/postgresql/collection.go 64.61% <0.00%> (-4.05%) ⬇️

... and 15 files with indirect coverage changes

Flag Coverage Δ
filter-true 57.64% <5.55%> (-0.56%) ⬇️
hana-1 ?
integration 57.64% <5.55%> (-0.56%) ⬇️
mongodb-1 4.48% <0.00%> (-0.02%) ⬇️
postgresql-1 41.15% <5.55%> (-0.13%) ⬇️
postgresql-2 41.68% <4.44%> (-0.11%) ⬇️
postgresql-3 39.99% <4.44%> (-0.06%) ⬇️
sort-false 57.64% <5.55%> (-0.56%) ⬇️
sqlite-1 ∅ <ø> (∅)
sqlite-2 41.85% <1.11%> (-0.12%) ⬇️
sqlite-3 39.96% <1.11%> (-0.15%) ⬇️
unit 22.39% <27.77%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup added the code/feature Some user-visible feature is not implemented yet label Oct 6, 2023
@noisersup noisersup marked this pull request as ready for review October 6, 2023 00:15
@noisersup noisersup requested review from AlekSi and a team as code owners October 6, 2023 00:15
@noisersup noisersup requested review from rumyantseva, a team and chilagrow October 6, 2023 00:15
chilagrow
chilagrow reviewed Oct 6, 2023
View reviewed changes
Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comment related to sort pushdown part of the code 🤗

internal/handlers/sqlite/msg_explain.go Show resolved Hide resolved
internal/backends/postgresql/query.go Outdated Show resolved Hide resolved
internal/backends/postgresql/collection.go Outdated Show resolved Hide resolved
internal/backends/postgresql/query.go Outdated Show resolved Hide resolved
internal/backends/collection.go Outdated Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Oct 6, 2023

@noisersup this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Oct 6, 2023
@mergify mergify bot removed the conflict PRs that have merge conflicts label Oct 9, 2023
AlekSi
AlekSi reviewed Oct 11, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it is still in progress

chilagrow
chilagrow previously approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

AlekSi
AlekSi reviewed Oct 13, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter fails

internal/handlers/sqlite/msg_find.go Outdated Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Oct 13, 2023

@noisersup this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Oct 13, 2023
@mergify mergify bot removed the conflict PRs that have merge conflicts label Oct 13, 2023
@noisersup noisersup requested a review from AlekSi October 16, 2023 02:53
@noisersup noisersup requested a review from AlekSi October 17, 2023 08:05
@noisersup noisersup merged commit a7cc841 into FerretDB:main Oct 17, 2023
26 of 27 checks passed
@noisersup noisersup deleted the postgresql-sort-pushdown-3415 branch October 17, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva

Assignees

@noisersup noisersup

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.

Implement sort pushdown
4 participants
@noisersup @AlekSi @rumyantseva @chilagrow