Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some fluky tests #351

Merged
merged 12 commits into from
Mar 23, 2022
Merged

Fix some fluky tests #351

merged 12 commits into from
Mar 23, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Mar 10, 2022

Refs #335.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Mar 10, 2022
@AlekSi AlekSi added this to the v0.0.7 milestone Mar 10, 2022
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #351 (52b256f) into main (0ec1502) will increase coverage by 1.64%.
The diff coverage is n/a.

❗ Current head 52b256f differs from pull request most recent head cc157a1. Consider uploading reports for the commit cc157a1 to get more accurate results

@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
+ Coverage   49.28%   50.93%   +1.64%     
==========================================
  Files         114      118       +4     
  Lines        5440     5847     +407     
==========================================
+ Hits         2681     2978     +297     
- Misses       2323     2427     +104     
- Partials      436      442       +6     
Impacted Files Coverage Δ
internal/handlers/common/params.go 42.85% <0.00%> (-7.15%) ⬇️
internal/handlers/msg_collstats.go 54.54% <0.00%> (-2.60%) ⬇️
internal/handlers/command.go 66.66% <0.00%> (-2.57%) ⬇️
cmd/envtool/main.go 0.00% <0.00%> (ø)
internal/types/types.go 94.11% <0.00%> (ø)
internal/types/document.go 78.66% <0.00%> (ø)
internal/clientconn/conn.go 0.00% <0.00%> (ø)
internal/handlers/common/filter.go
internal/handlers/common/compare.go
internal/handlers/jsonb1/msg_count.go
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd763a1...cc157a1. Read the comment docs.

@AlekSi AlekSi changed the title Fix fluky tests Fix some fluky tests Mar 10, 2022
@AlekSi AlekSi marked this pull request as ready for review March 10, 2022 15:01
seeforschauer
seeforschauer previously approved these changes Mar 10, 2022
@seeforschauer
Copy link
Contributor

but. lints not passed

@AlekSi
Copy link
Member Author

AlekSi commented Mar 10, 2022

Yeah, that line fails sometimes, trying to understand how…

@AlekSi AlekSi marked this pull request as draft March 10, 2022 15:41
@AlekSi AlekSi added the trust PRs that can access Actions secrets label Mar 11, 2022
@AlekSi AlekSi marked this pull request as ready for review March 23, 2022 19:11
@AlekSi AlekSi merged commit 7c99790 into FerretDB:main Mar 23, 2022
@AlekSi AlekSi deleted the fix-fluky-tests branch March 23, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements trust PRs that can access Actions secrets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants