Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic logging for PostgreSQL backend #3560

Merged
merged 5 commits into from Oct 13, 2023
Merged

Add basic logging for PostgreSQL backend #3560

merged 5 commits into from Oct 13, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 11, 2023

Description

Currently, there is none.

Refs #3554.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/enhancement Some user-visible feature could work better label Oct 11, 2023
@AlekSi AlekSi added this to the Next milestone Oct 11, 2023
@AlekSi AlekSi self-assigned this Oct 11, 2023
@AlekSi AlekSi enabled auto-merge (squash) October 11, 2023 15:20
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #3560 (82073e4) into main (f748ba9) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3560      +/-   ##
==========================================
- Coverage   61.37%   61.24%   -0.14%     
==========================================
  Files         426      426              
  Lines       27192    27200       +8     
==========================================
- Hits        16689    16658      -31     
- Misses       9512     9548      +36     
- Partials      991      994       +3     
Files Coverage Δ
...ternal/backends/postgresql/metadata/pool/opendb.go 61.25% <100.00%> (+4.30%) ⬆️

... and 6 files with indirect coverage changes

Flag Coverage Δ
filter-true 57.79% <100.00%> (-0.13%) ⬇️
hana-1 ?
integration 57.79% <100.00%> (-0.13%) ⬇️
mongodb-1 4.51% <0.00%> (-0.01%) ⬇️
postgresql-1 41.11% <100.00%> (+0.11%) ⬆️
postgresql-2 40.64% <100.00%> (+0.01%) ⬆️
postgresql-3 39.54% <100.00%> (+0.01%) ⬆️
sort-false 57.79% <100.00%> (-0.13%) ⬇️
sqlite-1 40.99% <0.00%> (-0.02%) ⬇️
sqlite-2 41.17% <0.00%> (-0.02%) ⬇️
sqlite-3 39.45% <0.00%> (-0.02%) ⬇️
unit 22.36% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

chilagrow
chilagrow previously approved these changes Oct 12, 2023
@AlekSi AlekSi disabled auto-merge October 13, 2023 09:03
@AlekSi AlekSi merged commit 52fe847 into FerretDB:main Oct 13, 2023
28 of 29 checks passed
@AlekSi AlekSi deleted the logs branch October 13, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/enhancement Some user-visible feature could work better
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants