Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQLite info to glossary list #3593

Merged
merged 5 commits into from Oct 18, 2023
Merged

Conversation

pvinoda
Copy link
Contributor

@pvinoda pvinoda commented Oct 17, 2023

  1. Added SQLite Info to Glossary List

  2. Kept the information similar to that of Postgres

Description

Closes #3427 .

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

1. Added SQLite Info to Glossary List

2. Kept the information similar to that of Postgres
@CLAassistant
Copy link

CLAassistant commented Oct 17, 2023

CLA assistant check
All committers have signed the CLA.

@AlekSi AlekSi changed the title Closes #3427 Add SQLite Info to glossary list Oct 17, 2023
@AlekSi AlekSi requested review from a team and Fashander October 17, 2023 04:43
@AlekSi
Copy link
Member

AlekSi commented Oct 17, 2023

@pvinoda Please click the CLA button in that comment: #3593 (comment)

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #3593 (7fb75ca) into main (d7493f7) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3593      +/-   ##
==========================================
- Coverage   61.54%   61.51%   -0.03%     
==========================================
  Files         426      426              
  Lines       27473    27473              
==========================================
- Hits        16907    16899       -8     
- Misses       9562     9567       +5     
- Partials     1004     1007       +3     

see 4 files with indirect coverage changes

Flag Coverage Δ
filter-true 58.03% <ø> (-0.02%) ⬇️
hana-1 3.03% <ø> (ø)
integration 58.03% <ø> (-0.02%) ⬇️
mongodb-1 4.50% <ø> (ø)
postgresql-1 41.12% <ø> (+0.06%) ⬆️
postgresql-2 41.68% <ø> (-0.01%) ⬇️
postgresql-3 39.95% <ø> (ø)
sort-false 58.03% <ø> (-0.02%) ⬇️
sqlite-1 40.96% <ø> (-0.10%) ⬇️
sqlite-2 41.87% <ø> (+<0.01%) ⬆️
sqlite-3 40.04% <ø> (+0.05%) ⬆️
unit 22.37% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@pvinoda
Copy link
Contributor Author

pvinoda commented Oct 18, 2023

@AlekSi I accepted the CLA. I see that a PR job is failing. Should I change any assert statements or any reformatting issues as such ?

@AlekSi
Copy link
Member

AlekSi commented Oct 18, 2023

Should be good now :)

@AlekSi AlekSi changed the title Add SQLite Info to glossary list Add SQLite info to glossary list Oct 18, 2023
@AlekSi AlekSi enabled auto-merge (squash) October 18, 2023 11:28
AlekSi
AlekSi previously approved these changes Oct 18, 2023
@AlekSi AlekSi added documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets labels Oct 18, 2023
@AlekSi AlekSi added this to the Next milestone Oct 18, 2023
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@AlekSi AlekSi merged commit 0d9e48c into FerretDB:main Oct 18, 2023
27 of 28 checks passed
@AlekSi
Copy link
Member

AlekSi commented Oct 18, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add SQLite info to glossary list
4 participants