Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify MongoDB version #3653

Merged
merged 2 commits into from Nov 20, 2023
Merged

Clarify MongoDB version #3653

merged 2 commits into from Nov 20, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 25, 2023

Description

We have three options:

  • say "MongoDB" or "modern MongoDB" (implying that we are not stuck in pre-5.0 days);
  • say "MongoDB 5.0+" or similar (implying the same);
  • say "MongoDB 7.0+" or similar (that's the version we actively test).

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the documentation Something user-visible is badly or not documented label Oct 25, 2023
@AlekSi AlekSi added this to the Next milestone Oct 25, 2023
@AlekSi AlekSi self-assigned this Oct 25, 2023
@AlekSi AlekSi requested review from a team and Fashander October 25, 2023 14:07
@AlekSi AlekSi enabled auto-merge (squash) October 25, 2023 14:08
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #3653 (166f43f) into main (329efdf) will decrease coverage by 0.65%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3653      +/-   ##
==========================================
- Coverage   62.59%   61.94%   -0.65%     
==========================================
  Files         430      430              
  Lines       27887    27887              
==========================================
- Hits        17455    17274     -181     
- Misses       9411     9574     +163     
- Partials     1021     1039      +18     

see 19 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 58.59% <ø> (-0.61%) ⬇️
hana-1 ?
integration 58.59% <ø> (-0.64%) ⬇️
mongodb-1 4.42% <ø> (ø)
postgresql-1 42.91% <ø> (-0.31%) ⬇️
postgresql-2 40.24% <ø> (-0.33%) ⬇️
postgresql-3 42.53% <ø> (-0.36%) ⬇️
sort-false 58.59% <ø> (-0.19%) ⬇️
sort-true ?
sqlite-1 42.32% <ø> (-0.19%) ⬇️
sqlite-2 39.69% <ø> (-0.23%) ⬇️
sqlite-3 41.84% <ø> (-0.55%) ⬇️
unit 22.70% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Fashander
Copy link
Member

Is "latest MongoDB" an option here for "modern MongoDB"? I'm guessing it can be latest MongoDB wire protocol

@AlekSi
Copy link
Member Author

AlekSi commented Oct 25, 2023

The wire protocol did not change since 5.0

@Fashander
Copy link
Member

In that case, "modern MongoDB" is apt, as it covers beyond pre-5.0

@AlekSi AlekSi modified the milestones: v1.14.0, Next Nov 7, 2023
@AlekSi AlekSi modified the milestone: Next Nov 20, 2023
@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Nov 20, 2023
@AlekSi AlekSi disabled auto-merge November 20, 2023 13:33
@AlekSi AlekSi merged commit 23103e2 into FerretDB:main Nov 20, 2023
18 of 20 checks passed
@AlekSi AlekSi deleted the remove-version branch November 20, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Something user-visible is badly or not documented not ready Issues that are not ready to be worked on; PRs that should skip CI
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants