-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tracing to envtool tests run
#3695
Conversation
envtool tests run
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3695 +/- ##
==========================================
- Coverage 32.31% 31.85% -0.47%
==========================================
Files 315 316 +1
Lines 23583 23586 +3
==========================================
- Hits 7622 7514 -108
- Misses 15277 15393 +116
+ Partials 684 679 -5
... and 7 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see where this PR adds spans to envtool tests run
command implementation in envtool.go
. This issue is about adding tracing to it, not to its tests.
Please also run task all
(or at least task fmt lint
) locally.
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not what needs to be done in that issue.
Let's use one trace per top-level test and spans for subtests
Not one span per go test
invocation and one tracing event per decoded event. We need to start span when the decoded event indicates that the test started, end span when the test ends, handle paused and continued tests, etc.
@hungaikev this pull request has merge conflicts. |
@hungaikev any news? Anything we could help you with? |
Hi @AlekSi would you be willing or available for a <= 15-minute block for us to go through this together to reduce the back and forth? I have a feeling that the part left is very small but seems to be taking 80% of the effort. |
@rumyantseva PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, with the current approach, we can see when a particular event (run, continue, pause, pass) happened for each subtest. Looks good to me.
Description
Adding tracing to envtool tests run
Closes #3665
Readiness checklist
task all
, and it passed.@FerretDB/core
), Milestone (Next
), Labels, Project and project's Sprint fields.