Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use - in addition to the empty string #3704

Merged
merged 1 commit into from Nov 13, 2023
Merged

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Nov 13, 2023

Description

Closes #3699.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned AlekSi Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #3704 (110607e) into main (db7342a) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3704      +/-   ##
==========================================
- Coverage   76.36%   76.23%   -0.13%     
==========================================
  Files         323      323              
  Lines       23029    23029              
==========================================
- Hits        17585    17557      -28     
- Misses       4406     4434      +28     
  Partials     1038     1038              

see 6 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.27% <ø> (-0.13%) ⬇️
hana-1 ?
integration 72.27% <ø> (-0.13%) ⬇️
mongodb-1 5.47% <ø> (ø)
postgresql-1 52.43% <ø> (-0.06%) ⬇️
postgresql-2 51.63% <ø> (-0.01%) ⬇️
postgresql-3 50.69% <ø> (ø)
sort-false 72.27% <ø> (-0.13%) ⬇️
sqlite-1 51.83% <ø> (ø)
sqlite-2 50.85% <ø> (-0.01%) ⬇️
sqlite-3 49.90% <ø> (ø)
unit 30.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Nov 13, 2023
@AlekSi AlekSi added this to the Next milestone Nov 13, 2023
@AlekSi AlekSi marked this pull request as ready for review November 13, 2023 19:33
@AlekSi AlekSi requested review from ptrfarkas and a team as code owners November 13, 2023 19:33
@AlekSi AlekSi merged commit a58d9f8 into FerretDB:main Nov 13, 2023
28 of 33 checks passed
@AlekSi AlekSi deleted the empty-string branch November 13, 2023 20:02
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Allow usage without state dir
1 participant