Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the standard *mongo.WriteError type #3705

Merged
merged 2 commits into from Nov 13, 2023
Merged

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Nov 13, 2023

Description

To avoid introducing our own type.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned AlekSi Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #3705 (9f0c367) into main (a58d9f8) will decrease coverage by 0.10%.
The diff coverage is 69.76%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3705      +/-   ##
==========================================
- Coverage   76.27%   76.17%   -0.10%     
==========================================
  Files         323      323              
  Lines       23029    23029              
==========================================
- Hits        17566    17543      -23     
- Misses       4422     4444      +22     
- Partials     1041     1042       +1     
Files Coverage Δ
internal/handlers/sqlite/msg_delete.go 76.23% <100.00%> (ø)
internal/handlers/sqlite/msg_insert.go 79.52% <100.00%> (ø)
internal/handlers/sqlite/msg_update.go 74.13% <100.00%> (ø)
internal/handlers/sqlite/msg_findandmodify.go 66.40% <7.14%> (ø)

... and 12 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.20% <69.76%> (-0.11%) ⬇️
hana-1 ?
integration 72.20% <69.76%> (-0.11%) ⬇️
mongodb-1 5.47% <0.00%> (?)
postgresql-1 52.49% <58.13%> (ø)
postgresql-2 51.64% <32.55%> (ø)
postgresql-3 50.69% <41.86%> (ø)
sort-false 72.20% <69.76%> (-0.11%) ⬇️
sqlite-1 51.67% <58.13%> (-0.16%) ⬇️
sqlite-2 50.86% <32.55%> (+<0.01%) ⬆️
sqlite-3 49.90% <41.86%> (ø)
unit 30.08% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added this to the Next milestone Nov 13, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Nov 13, 2023
@AlekSi AlekSi marked this pull request as ready for review November 13, 2023 21:57
@AlekSi AlekSi requested a review from a team as a code owner November 13, 2023 21:57
@AlekSi AlekSi merged commit d743808 into FerretDB:main Nov 13, 2023
27 of 29 checks passed
@AlekSi AlekSi deleted the write-error branch November 13, 2023 21:58
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant