Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TODOs and fix URLs #3723

Merged
merged 2 commits into from Nov 17, 2023
Merged

Add TODOs and fix URLs #3723

merged 2 commits into from Nov 17, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Nov 17, 2023

Description

Tiny changes.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi changed the title Todos Add TODOs and fix URLs Nov 17, 2023
@mergify mergify bot assigned AlekSi Nov 17, 2023
@AlekSi AlekSi added this to the Next milestone Nov 17, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Nov 17, 2023
@AlekSi AlekSi marked this pull request as ready for review November 17, 2023 08:45
@AlekSi AlekSi requested review from ptrfarkas and a team as code owners November 17, 2023 08:45
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #3723 (3b0e91b) into main (3ed16c6) will decrease coverage by 0.46%.
The diff coverage is 75.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3723      +/-   ##
==========================================
- Coverage   31.90%   31.44%   -0.46%     
==========================================
  Files         323      323              
  Lines       23063    23069       +6     
==========================================
- Hits         7359     7255     -104     
- Misses      15027    15141     +114     
+ Partials      677      673       -4     
Files Coverage Δ
internal/backends/postgresql/collection.go 43.67% <100.00%> (+0.27%) ⬆️
internal/backends/sqlite/collection.go 51.05% <100.00%> (+0.25%) ⬆️
internal/handlers/sqlite/msg_insert.go 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes

Flag Coverage Δ
filter-true 5.45% <0.00%> (-0.79%) ⬇️
hana-1 ?
integration 5.45% <0.00%> (-0.79%) ⬇️
mongodb-1 5.45% <0.00%> (-0.01%) ⬇️
sort-false 5.45% <0.00%> (-0.79%) ⬇️
unit 30.17% <75.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi merged commit 8e27db3 into FerretDB:main Nov 17, 2023
26 of 30 checks passed
@AlekSi AlekSi deleted the todos branch November 17, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant