Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove common handlers.Interface #3753

Merged
merged 2 commits into from Nov 23, 2023
Merged

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Nov 23, 2023

Description

Closes #3662.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Nov 23, 2023
@AlekSi AlekSi added this to the Next milestone Nov 23, 2023
@mergify mergify bot assigned AlekSi Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #3753 (7f8654b) into main (3d03b51) will increase coverage by 0.01%.
The diff coverage is 93.93%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3753      +/-   ##
==========================================
+ Coverage   76.26%   76.28%   +0.01%     
==========================================
  Files         325      324       -1     
  Lines       23112    23116       +4     
==========================================
+ Hits        17627    17633       +6     
- Misses       4441     4444       +3     
+ Partials     1044     1039       -5     
Files Coverage Δ
internal/clientconn/conn.go 55.49% <100.00%> (ø)
internal/clientconn/listener.go 75.35% <ø> (ø)
internal/handlers/registry/postgresql.go 77.77% <100.00%> (ø)
internal/handlers/registry/registry.go 43.47% <100.00%> (ø)
internal/handlers/registry/sqlite.go 77.77% <100.00%> (ø)
internal/handlers/sqlite/cmd_query.go 32.00% <ø> (ø)
internal/handlers/sqlite/msg_aggregate.go 83.78% <ø> (ø)
internal/handlers/sqlite/msg_buildinfo.go 100.00% <ø> (ø)
internal/handlers/sqlite/msg_collmod.go 0.00% <ø> (ø)
internal/handlers/sqlite/msg_collstats.go 73.68% <ø> (ø)
... and 43 more

... and 8 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.44% <93.93%> (+0.03%) ⬆️
hana-1 ?
integration 72.44% <93.93%> (+0.03%) ⬆️
mongodb-1 5.47% <18.18%> (+0.02%) ⬆️
postgresql-1 51.78% <30.30%> (+0.02%) ⬆️
postgresql-2 51.39% <90.90%> (+<0.01%) ⬆️
postgresql-3 52.56% <30.30%> (+0.14%) ⬆️
sqlite-1 50.92% <30.30%> (+0.05%) ⬆️
sqlite-2 50.55% <90.90%> (+<0.01%) ⬆️
sqlite-3 51.62% <30.30%> (?)
unit 30.13% <27.27%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review November 23, 2023 13:45
@AlekSi AlekSi requested a review from a team as a code owner November 23, 2023 13:45
@AlekSi AlekSi enabled auto-merge (squash) November 23, 2023 13:45
@AlekSi AlekSi requested review from a team and noisersup November 23, 2023 13:45
internal/clientconn/conn.go Show resolved Hide resolved
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlekSi AlekSi merged commit e60e99b into FerretDB:main Nov 23, 2023
28 of 30 checks passed
@AlekSi AlekSi deleted the remove-interface branch November 23, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Move and rename the handler
3 participants