Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some small improvements to the linter that checks open issues #3756

Merged
merged 31 commits into from Dec 25, 2023

Conversation

rumyantseva
Copy link
Member

@rumyantseva rumyantseva commented Nov 24, 2023

Description

Closes #2733.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva self-assigned this Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (235a208) 75.24% compared to head (ebfdca3) 73.81%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3756      +/-   ##
==========================================
- Coverage   75.24%   73.81%   -1.43%     
==========================================
  Files         330      330              
  Lines       25595    25595              
==========================================
- Hits        19258    18892     -366     
- Misses       5192     5574     +382     
+ Partials     1145     1129      -16     

see 28 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 70.48% <ø> (-1.92%) ⬇️
hana-1 ?
integration 70.48% <ø> (-1.94%) ⬇️
mongodb-1 5.08% <ø> (ø)
mysql-1 ?
postgresql-1 51.00% <ø> (-14.15%) ⬇️
postgresql-2 49.62% <ø> (-0.06%) ⬇️
postgresql-3 51.91% <ø> (-0.11%) ⬇️
sqlite-1 50.18% <ø> (-14.19%) ⬇️
sqlite-2 48.63% <ø> (-0.10%) ⬇️
sqlite-3 51.17% <ø> (ø)
unit 30.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@rumyantseva rumyantseva added this to the Next milestone Dec 4, 2023
@rumyantseva rumyantseva added the code/chore Code maintenance improvements label Dec 4, 2023
@rumyantseva rumyantseva marked this pull request as ready for review December 4, 2023 14:02
@rumyantseva rumyantseva enabled auto-merge (squash) December 4, 2023 14:02
@rumyantseva rumyantseva requested review from a team, henvic and noisersup December 4, 2023 14:02
henvic
henvic previously approved these changes Dec 4, 2023
tools/checkcomments/checkcomments.go Outdated Show resolved Hide resolved
tools/checkcomments/checkcomments.go Outdated Show resolved Hide resolved
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with the current approach is that we process one package at a time. There is quite a lot of work we can do with more concurrency

tools/checkcomments/checkcomments.go Outdated Show resolved Hide resolved
tools/checkcomments/checkcomments.go Outdated Show resolved Hide resolved
tools/checkcomments/checkcomments.go Outdated Show resolved Hide resolved
@AlekSi
Copy link
Member

AlekSi commented Dec 4, 2023

Currently, the file that caches issues doesn't have a process to be updated.

FerretDB/Taskfile.yml

Lines 480 to 481 in f4c289f

- bin/envtool{{exeExt}} shell rmdir tmp/checkcomments
- bin/envtool{{exeExt}} shell mkdir tmp/checkcomments

@AlekSi
Copy link
Member

AlekSi commented Dec 4, 2023

It's not easy to make it write the message only once as run is called for each directory separately

It's a good thing we have a locked file, then…

@rumyantseva rumyantseva added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Dec 5, 2023
@rumyantseva rumyantseva removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Dec 7, 2023
@rumyantseva
Copy link
Member Author

Thanks @henvic for your help with this PR :)

henvic
henvic previously approved these changes Dec 7, 2023
@AlekSi AlekSi marked this pull request as draft December 8, 2023 10:30
auto-merge was automatically disabled December 8, 2023 10:30

Pull request was converted to draft

@AlekSi AlekSi modified the milestones: v1.17.0, Next Dec 18, 2023
@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Dec 25, 2023
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Dec 25, 2023
@AlekSi AlekSi marked this pull request as ready for review December 25, 2023 16:43
@AlekSi AlekSi merged commit e36e848 into FerretDB:main Dec 25, 2023
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Make linter for checking that linked issues are open
3 participants