Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove done TODOs #3795

Merged
merged 2 commits into from Dec 1, 2023
Merged

Remove done TODOs #3795

merged 2 commits into from Dec 1, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Dec 1, 2023

Description

Closes #3742.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned AlekSi Dec 1, 2023
@AlekSi AlekSi added this to the Next milestone Dec 1, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #3795 (94393b0) into main (e073f9d) will decrease coverage by 0.07%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3795      +/-   ##
==========================================
- Coverage   76.32%   76.25%   -0.07%     
==========================================
  Files         315      315              
  Lines       23506    23506              
==========================================
- Hits        17940    17925      -15     
- Misses       4524     4538      +14     
- Partials     1042     1043       +1     
Files Coverage Δ
internal/backends/collection.go 92.62% <ø> (ø)

... and 10 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.40% <ø> (-0.07%) ⬇️
hana-1 ?
integration 72.40% <ø> (-0.07%) ⬇️
mongodb-1 5.36% <ø> (ø)
postgresql-1 51.36% <ø> (ø)
postgresql-2 52.69% <ø> (-0.12%) ⬇️
postgresql-3 52.15% <ø> (+<0.01%) ⬆️
sqlite-1 50.60% <ø> (ø)
sqlite-2 51.91% <ø> (+0.06%) ⬆️
sqlite-3 51.20% <ø> (-0.04%) ⬇️
unit 30.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review December 1, 2023 05:44
@AlekSi AlekSi enabled auto-merge (squash) December 1, 2023 05:44
@AlekSi AlekSi requested review from a team, henvic, rumyantseva and noisersup December 1, 2023 05:44
@AlekSi AlekSi merged commit c127482 into FerretDB:main Dec 1, 2023
28 checks passed
@AlekSi AlekSi deleted the todos branch December 1, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Return information about sort pushdown
3 participants