Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set GOARM explicitly #3796

Merged
merged 8 commits into from Dec 4, 2023
Merged

Set GOARM explicitly #3796

merged 8 commits into from Dec 4, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Dec 1, 2023 •
edited

Description

Make arm/v7 Docker images include arm/v7 binary, not arm/v6.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added code/chore Code maintenance improvements trust PRs that can access Actions secrets packages PRs that should build packages labels Dec 1, 2023
@mergify mergify bot assigned AlekSi Dec 1, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 1, 2023 •
edited

Codecov Report

Merging #3796 (3e99901) into main (ced8ce0) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3796      +/-   ##
==========================================
+ Coverage   76.29%   76.33%   +0.04%     
==========================================
  Files         315      315              
  Lines       23520    23520              
==========================================
+ Hits        17944    17954      +10     
+ Misses       4530     4524       -6     
+ Partials     1046     1042       -4

see 8 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.48% <ø> (+0.04%) ⬆️
hana-1 3.47% <ø> (ø)
integration 72.48% <ø> (+0.04%) ⬆️
mongodb-1 5.35% <ø> (ø)
postgresql-1 51.41% <ø> (ø)
postgresql-2 52.68% <ø> (ø)
postgresql-3 52.18% <ø> (ø)
sqlite-1 50.65% <ø> (ø)
sqlite-2 51.94% <ø> (+0.05%) ⬆️
sqlite-3 51.27% <ø> (+0.01%) ⬆️
unit 30.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added this to the Next milestone Dec 1, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 1, 2023

@AlekSi this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Dec 1, 2023
@AlekSi
Update domain name in more places
15918c1
@AlekSi
Merge branch 'domain' into goarm
b0f8a57 
# Conflicts:
#	README.md
#	build/nfpm.yml
#	website/docs/main.md
@mergify mergify bot removed the conflict PRs that have merge conflicts label Dec 1, 2023
@AlekSi AlekSi marked this pull request as ready for review December 1, 2023 14:27
@AlekSi AlekSi enabled auto-merge (squash) December 1, 2023 14:27
@AlekSi AlekSi requested review from a team, henvic, rumyantseva and noisersup December 1, 2023 14:27
henvic
henvic previously approved these changes Dec 1, 2023
View reviewed changes
build/docker/all-in-one.Dockerfile Outdated Show resolved Hide resolved
@AlekSi @henvic
Update build/docker/all-in-one.Dockerfile
d8ad249 
Co-authored-by: Henrique Vicente <henriquevicente@gmail.com>
@AlekSi AlekSi requested a review from henvic December 1, 2023 15:22
noisersup
noisersup approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi disabled auto-merge December 4, 2023 08:39
@AlekSi AlekSi merged commit c7de1c4 into FerretDB:main Dec 4, 2023
28 of 29 checks passed
@AlekSi AlekSi deleted the goarm branch December 4, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva was automatically assigned from FerretDB/core

@henvic henvic Awaiting requested review from henvic

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements packages PRs that should build packages trust PRs that can access Actions secrets
Projects
Current Engineering
Archived in project
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlekSi @henvic @noisersup