Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix small issues after rewrite #380

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Fix small issues after rewrite #380

merged 2 commits into from
Mar 21, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Mar 21, 2022

No description provided.

@AlekSi AlekSi added this to the v0.0.7 milestone Mar 21, 2022
@AlekSi AlekSi added code/chore Code maintenance improvements trust PRs that can access Actions secrets labels Mar 21, 2022
seeforschauer
seeforschauer reviewed Mar 21, 2022
View reviewed changes
internal/handlers/jsonb1/msg_count.go Show resolved Hide resolved
internal/handlers/jsonb1/msg_count.go
var limit int32
if filter, err = common.GetOptionalParam(document, "query", filter); err != nil {
return nil, err
}
if sort, err = common.GetOptionalParam(document, "sort", sort); err != nil {
return nil, err
}
if limit, err = common.GetOptionalParam(document, "limit", limit); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

limit is not necessary for count, isn't it?

seeforschauer
seeforschauer suggested changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@seeforschauer seeforschauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls remove limit from count

@AlekSi
Copy link
Member Author

AlekSi commented Mar 21, 2022

We actually need limit:

monila> db.runCommand({count: 'actor', limit: 2})
{ n: 2, ok: 1 }

Header diff:
--- res header
+++ proxy header
@@ -1 +1 @@
-length:    45, id:   14, response_to:   17, opcode: OP_MSG
+length:    45, id:  179, response_to:   17, opcode: OP_MSG

Body diff:

@AlekSi AlekSi merged commit b0804b4 into FerretDB:main Mar 21, 2022
@AlekSi AlekSi deleted the small-fixes branch March 21, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seeforschauer seeforschauer seeforschauer approved these changes

@w84thesun w84thesun Awaiting requested review from w84thesun

Assignees
No one assigned
Labels
code/chore Code maintenance improvements trust PRs that can access Actions secrets
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlekSi @seeforschauer