Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve validate diagnostic command #3804

Merged
merged 10 commits into from Dec 4, 2023
Merged

Conversation

b1ron
Copy link
Contributor

@b1ron b1ron commented Dec 4, 2023

Description

Closes #419.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@b1ron b1ron added code/enhancement Some user-visible feature could work better area/diag Issues about diagnostic commands labels Dec 4, 2023
@b1ron b1ron self-assigned this Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #3804 (233f9e2) into main (f4c289f) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3804      +/-   ##
==========================================
- Coverage   76.38%   76.24%   -0.14%     
==========================================
  Files         315      315              
  Lines       23540    23540              
==========================================
- Hits        17980    17949      -31     
- Misses       4519     4549      +30     
- Partials     1041     1042       +1     
Files Coverage Δ
internal/handler/msg_validate.go 69.23% <100.00%> (ø)

... and 10 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.39% <100.00%> (-0.14%) ⬇️
hana-1 ?
integration 72.39% <100.00%> (-0.14%) ⬇️
mongodb-1 5.19% <0.00%> (-0.16%) ⬇️
postgresql-1 52.34% <100.00%> (ø)
postgresql-2 51.28% <100.00%> (-0.01%) ⬇️
postgresql-3 52.98% <100.00%> (-0.03%) ⬇️
sqlite-1 51.47% <100.00%> (+0.09%) ⬆️
sqlite-2 50.43% <100.00%> (ø)
sqlite-3 52.10% <100.00%> (-0.13%) ⬇️
unit 30.73% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@b1ron b1ron requested review from a team, henvic, rumyantseva and noisersup December 4, 2023 11:29
@b1ron b1ron marked this pull request as ready for review December 4, 2023 11:29
@b1ron b1ron requested review from AlekSi, ptrfarkas and a team as code owners December 4, 2023 11:29
@AlekSi AlekSi added this to the Next milestone Dec 4, 2023
@b1ron b1ron enabled auto-merge (squash) December 4, 2023 11:30
@b1ron
Copy link
Contributor Author

b1ron commented Dec 4, 2023

Tests are failing let me investigate.

@AlekSi AlekSi changed the title Improve validate command Improve validate diagnostic command Dec 4, 2023
@AlekSi AlekSi disabled auto-merge December 4, 2023 16:57
@AlekSi AlekSi enabled auto-merge (squash) December 4, 2023 16:57
@AlekSi AlekSi merged commit 126b59d into FerretDB:main Dec 4, 2023
28 of 30 checks passed
@AlekSi
Copy link
Member

AlekSi commented Dec 4, 2023

:shipit:

@b1ron b1ron deleted the improve-validate branch December 5, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/diag Issues about diagnostic commands code/enhancement Some user-visible feature could work better
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Improve validate diagnostic command
3 participants