-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve validate
diagnostic command
#3804
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1ron
added
code/enhancement
Some user-visible feature could work better
area/diag
Issues about diagnostic commands
labels
Dec 4, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3804 +/- ##
==========================================
- Coverage 76.38% 76.24% -0.14%
==========================================
Files 315 315
Lines 23540 23540
==========================================
- Hits 17980 17949 -31
- Misses 4519 4549 +30
- Partials 1041 1042 +1
... and 10 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
b1ron
commented
Dec 4, 2023
Tests are failing let me investigate. |
henvic
approved these changes
Dec 4, 2023
AlekSi
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/diag
Issues about diagnostic commands
code/enhancement
Some user-visible feature could work better
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #419.
Readiness checklist
task all
, and it passed.@FerretDB/core
), Milestone (Next
), Labels, Project and project's Sprint fields.