Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields to listCollections.cursor response #3809

Merged
merged 12 commits into from Dec 8, 2023

Conversation

henvic
Copy link
Contributor

@henvic henvic commented Dec 5, 2023

Description

Add extra fields to ListCollections.cursor.

Closes #2815.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned henvic Dec 5, 2023
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #3809 (21cdc73) into main (13d2680) will decrease coverage by 0.50%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3809      +/-   ##
==========================================
- Coverage   76.66%   76.17%   -0.50%     
==========================================
  Files         316      316              
  Lines       23635    23655      +20     
==========================================
- Hits        18120    18019     -101     
- Misses       4472     4589     +117     
- Partials     1043     1047       +4     
Files Coverage Δ
internal/handler/msg_listcollections.go 73.00% <100.00%> (+6.75%) ⬆️

... and 17 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 72.32% <100.00%> (-0.29%) ⬇️
hana-1 ?
integration 72.32% <100.00%> (-0.53%) ⬇️
mongodb-1 5.18% <0.00%> (-0.01%) ⬇️
mysql-1 ?
mysql-2 ?
mysql-3 ?
postgresql-1 51.99% <100.00%> (-0.47%) ⬇️
postgresql-2 52.26% <59.09%> (+0.72%) ⬆️
postgresql-3 52.14% <59.09%> (-0.49%) ⬇️
sqlite-1 51.20% <100.00%> (-0.50%) ⬇️
sqlite-2 51.39% <59.09%> (+0.57%) ⬆️
sqlite-3 51.25% <59.09%> (-0.52%) ⬇️
unit 30.65% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No backend changes are needed in this issue/PR

internal/backends/database.go Outdated Show resolved Hide resolved
internal/backends/database.go Outdated Show resolved Hide resolved
internal/handler/msg_listcollections.go Outdated Show resolved Hide resolved
@henvic henvic added the area/cursors Issues about cursors label Dec 7, 2023
@henvic henvic marked this pull request as ready for review December 7, 2023 00:32
@henvic henvic requested a review from a team as a code owner December 7, 2023 00:32
@AlekSi AlekSi requested review from a team and noisersup December 7, 2023 04:18
@AlekSi AlekSi added this to the Next milestone Dec 7, 2023
@AlekSi
Copy link
Member

AlekSi commented Dec 7, 2023

(for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.

@henvic the maintainer is you. Please do that in the next PR.

I marked all done items in this checklist.

Please also do that.

@AlekSi AlekSi enabled auto-merge (squash) December 7, 2023 06:42
@AlekSi AlekSi changed the title Add fields to listCollections.cursor response Add fields to listCollections.cursor response Dec 7, 2023
@AlekSi AlekSi disabled auto-merge December 7, 2023 06:43
@AlekSi AlekSi enabled auto-merge (squash) December 7, 2023 06:43
internal/handler/msg_listcollections.go Outdated Show resolved Hide resolved
integration/commands_administration_test.go Outdated Show resolved Hide resolved
@henvic henvic added the code/enhancement Some user-visible feature could work better label Dec 7, 2023
@henvic henvic requested a review from AlekSi December 7, 2023 18:31
AlekSi
AlekSi previously approved these changes Dec 8, 2023
internal/handler/msg_listcollections.go Outdated Show resolved Hide resolved
rumyantseva
rumyantseva previously approved these changes Dec 8, 2023
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's strange that codecov shows the lines uncovered, but the implementation and the test look good to me.

@henvic henvic dismissed stale reviews from rumyantseva and AlekSi via 21cdc73 December 8, 2023 09:19
@AlekSi AlekSi merged commit 26b27de into FerretDB:main Dec 8, 2023
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cursors Issues about cursors code/enhancement Some user-visible feature could work better
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

listCollections.cursor document should contain more fields
3 participants