-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore $clusterTime
#3830
Ignore $clusterTime
#3830
Conversation
To make proxy mode usable again.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3830 +/- ##
==========================================
- Coverage 76.34% 76.09% -0.25%
==========================================
Files 316 316
Lines 23600 23600
==========================================
- Hits 18018 17959 -59
- Misses 4539 4590 +51
- Partials 1043 1051 +8
... and 11 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the required change really just adding this ClusterTime field on some structs and nothing else?
Oh, I saw the ignored annotation now! |
@henvic good, please re-approve :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (don't we need to do smth with the response too?..)
Description
To make proxy-diff mode usable again.
Readiness checklist
task all
, and it passed.@FerretDB/core
), Milestone (Next
), Labels, Project and project's Sprint fields.