Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore $clusterTime #3830

Merged
merged 2 commits into from Dec 7, 2023
Merged

Ignore $clusterTime #3830

merged 2 commits into from Dec 7, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Dec 7, 2023

Description

To make proxy-diff mode usable again.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

To make proxy mode usable again.
@AlekSi AlekSi added the code/chore Code maintenance improvements label Dec 7, 2023
@AlekSi AlekSi added this to the Next milestone Dec 7, 2023
@AlekSi AlekSi self-assigned this Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #3830 (26c09b0) into main (514acee) will decrease coverage by 0.25%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3830      +/-   ##
==========================================
- Coverage   76.34%   76.09%   -0.25%     
==========================================
  Files         316      316              
  Lines       23600    23600              
==========================================
- Hits        18018    17959      -59     
- Misses       4539     4590      +51     
- Partials     1043     1051       +8     
Files Coverage Δ
internal/handler/common/count.go 100.00% <ø> (ø)
internal/handler/common/delete_params.go 100.00% <ø> (ø)
internal/handler/common/distinct.go 79.71% <ø> (ø)
internal/handler/common/find.go 100.00% <ø> (ø)
internal/handler/common/findandmodify.go 26.08% <ø> (ø)
internal/handler/common/insert.go 100.00% <ø> (ø)
internal/handler/common/update_params.go 100.00% <ø> (ø)

... and 11 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.21% <ø> (-0.27%) ⬇️
hana-1 ?
integration 72.21% <ø> (-0.27%) ⬇️
mongodb-1 5.19% <ø> (ø)
postgresql-1 52.46% <ø> (-0.05%) ⬇️
postgresql-2 51.23% <ø> (-0.10%) ⬇️
postgresql-3 52.60% <ø> (ø)
sqlite-1 ?
sqlite-2 50.68% <ø> (+0.16%) ⬆️
sqlite-3 51.74% <ø> (-0.01%) ⬇️
unit 30.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review December 7, 2023 16:10
@AlekSi AlekSi requested a review from a team as a code owner December 7, 2023 16:10
@AlekSi AlekSi enabled auto-merge (squash) December 7, 2023 16:10
@AlekSi AlekSi requested review from a team, henvic and noisersup December 7, 2023 16:10
Copy link
Contributor

@henvic henvic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the required change really just adding this ClusterTime field on some structs and nothing else?

@AlekSi AlekSi requested a review from henvic December 7, 2023 16:13
@henvic
Copy link
Contributor

henvic commented Dec 7, 2023

Oh, I saw the ignored annotation now!

@AlekSi
Copy link
Member Author

AlekSi commented Dec 7, 2023

@henvic good, please re-approve :)

Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (don't we need to do smth with the response too?..)

@AlekSi AlekSi merged commit d8de8af into FerretDB:main Dec 7, 2023
29 of 32 checks passed
@AlekSi AlekSi deleted the cluster-time branch December 7, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants