Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow $natural in compound sort #3832

Merged
merged 1 commit into from Dec 8, 2023
Merged

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Dec 8, 2023

Description

Closes #3638.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@noisersup noisersup added the code/feature Some user-visible feature is not implemented yet label Dec 8, 2023
@noisersup noisersup self-assigned this Dec 8, 2023
@noisersup noisersup added this to the Next milestone Dec 8, 2023
@noisersup noisersup marked this pull request as ready for review December 8, 2023 11:22
@noisersup noisersup requested a review from a team as a code owner December 8, 2023 11:22
@noisersup noisersup enabled auto-merge (squash) December 8, 2023 11:22
@noisersup noisersup requested review from a team and henvic December 8, 2023 11:23
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #3832 (c402fdc) into main (26b27de) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3832      +/-   ##
==========================================
- Coverage   76.30%   76.18%   -0.13%     
==========================================
  Files         316      316              
  Lines       23655    23662       +7     
==========================================
- Hits        18051    18027      -24     
- Misses       4560     4588      +28     
- Partials     1044     1047       +3     
Files Coverage Δ
internal/handler/common/sort.go 85.80% <100.00%> (+0.64%) ⬆️

... and 13 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.34% <100.00%> (-0.13%) ⬇️
hana-1 ?
integration 72.34% <100.00%> (-0.13%) ⬇️
mongodb-1 5.18% <0.00%> (-0.01%) ⬇️
postgresql-1 52.08% <100.00%> (+0.09%) ⬆️
postgresql-2 52.25% <0.00%> (-0.07%) ⬇️
postgresql-3 52.13% <0.00%> (-0.05%) ⬇️
sqlite-1 51.35% <100.00%> (+0.04%) ⬆️
sqlite-2 51.38% <0.00%> (-0.02%) ⬇️
sqlite-3 51.25% <0.00%> (-0.03%) ⬇️
unit 30.64% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@noisersup noisersup merged commit c0eace0 into FerretDB:main Dec 8, 2023
30 of 31 checks passed
@noisersup noisersup deleted the fix-test branch December 8, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/feature Some user-visible feature is not implemented yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Allow sorting by $natural
3 participants