Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upsert tests #3864

Merged
merged 1 commit into from Dec 18, 2023
Merged

Add upsert tests #3864

merged 1 commit into from Dec 18, 2023

Conversation

wazir-ahmed
Copy link
Contributor

@wazir-ahmed wazir-ahmed commented Dec 17, 2023

Description

Closes #3856.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

Signed-off-by: Wazir Ahmed <wazirahmedf@gmail.com>
Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Merging #3864 (853a281) into main (39aee11) will decrease coverage by 0.41%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3864      +/-   ##
==========================================
- Coverage   76.39%   75.98%   -0.41%     
==========================================
  Files         317      317              
  Lines       23933    23933              
==========================================
- Hits        18283    18185      -98     
- Misses       4596     4688      +92     
- Partials     1054     1060       +6     

see 18 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 72.26% <ø> (-0.39%) ⬇️
hana-1 ?
integration 72.26% <ø> (-0.42%) ⬇️
mongodb-1 5.27% <ø> (ø)
mysql-1 ?
mysql-2 ?
mysql-3 ?
postgresql-1 52.13% <ø> (-0.07%) ⬇️
postgresql-2 50.74% <ø> (-0.10%) ⬇️
postgresql-3 53.10% <ø> (-0.09%) ⬇️
sqlite-1 51.33% <ø> (-0.15%) ⬇️
sqlite-2 49.80% <ø> (-0.09%) ⬇️
sqlite-3 52.19% <ø> (-0.03%) ⬇️
unit 30.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added code/chore Code maintenance improvements community Issues and PRs assigned to community members labels Dec 18, 2023
@AlekSi AlekSi added this to the Next milestone Dec 18, 2023
@AlekSi AlekSi self-assigned this Dec 18, 2023
@AlekSi AlekSi changed the title Add test cases for #3856 Add upsert tests Dec 18, 2023
@AlekSi AlekSi enabled auto-merge (squash) December 18, 2023 03:52
@AlekSi AlekSi requested review from a team, henvic and noisersup December 18, 2023 03:52
@AlekSi AlekSi merged commit 82143ff into FerretDB:main Dec 18, 2023
31 of 37 checks passed
@AlekSi AlekSi modified the milestones: Next, v1.17.0 Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements community Issues and PRs assigned to community members
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Filter fields not appended to new document properly when upsert: true
3 participants