Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop test users on cleanup #3914

Merged
merged 2 commits into from Dec 28, 2023
Merged

Drop test users on cleanup #3914

merged 2 commits into from Dec 28, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Dec 28, 2023

Description

Removes the need to do it in every test.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned AlekSi Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1b1167e) 75.02% compared to head (1b748bd) 73.85%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3914      +/-   ##
==========================================
- Coverage   75.02%   73.85%   -1.18%     
==========================================
  Files         330      330              
  Lines       25602    25610       +8     
==========================================
- Hits        19208    18913     -295     
- Misses       5238     5570     +332     
+ Partials     1156     1127      -29     
Files Coverage Δ
integration/setup/setup.go 80.21% <100.00%> (+0.44%) ⬆️
integration/setup/setup_compat.go 87.50% <100.00%> (+0.40%) ⬆️

... and 15 files with indirect coverage changes

Flag Coverage Δ
filter-true 70.52% <100.00%> (-1.50%) ⬇️
hana-1 ?
integration 70.52% <100.00%> (-1.50%) ⬇️
mongodb-1 5.24% <44.44%> (+0.01%) ⬆️
postgresql-1 51.15% <100.00%> (+0.14%) ⬆️
postgresql-2 49.65% <100.00%> (+0.04%) ⬆️
postgresql-3 51.90% <100.00%> (-0.11%) ⬇️
sqlite-1 50.26% <100.00%> (+0.13%) ⬆️
sqlite-2 48.67% <100.00%> (+0.01%) ⬆️
sqlite-3 51.07% <100.00%> (-0.09%) ⬇️
unit 30.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added this to the Next milestone Dec 28, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Dec 28, 2023
@AlekSi AlekSi marked this pull request as ready for review December 28, 2023 10:45
@AlekSi AlekSi requested a review from a team as a code owner December 28, 2023 10:45
@AlekSi AlekSi enabled auto-merge (squash) December 28, 2023 10:45
@AlekSi AlekSi requested review from a team, henvic and noisersup December 28, 2023 10:45
Copy link
Contributor

@henvic henvic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@AlekSi AlekSi merged commit ca74498 into FerretDB:main Dec 28, 2023
29 of 31 checks passed
@AlekSi AlekSi deleted the cleanup branch December 28, 2023 11:01
sachinpuranik pushed a commit to sachinpuranik/FerretDB that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants