Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the necessary for replica set fields to ismaster response #3925

Merged
merged 35 commits into from Jan 5, 2024
Merged

Add the necessary for replica set fields to ismaster response #3925

merged 35 commits into from Jan 5, 2024

Conversation

rumyantseva
Copy link
Member

@rumyantseva rumyantseva commented Jan 2, 2024 •
edited

Description

Closes #3556.

In this PR: the minimal necessary changes related to replica set params necessary to connect meteor to FerretDB.
Oplog collection needs to be created manually (as usual in FerretDB).

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jan 2, 2024
@rumyantseva rumyantseva self-assigned this Jan 2, 2024
@rumyantseva rumyantseva added this to the Next milestone Jan 2, 2024
@rumyantseva rumyantseva added the code/chore Code maintenance improvements label Jan 2, 2024
@AlekSi AlekSi added trust PRs that can access Actions secrets packages PRs that should build packages labels Jan 4, 2024
henvic
henvic previously approved these changes Jan 4, 2024
View reviewed changes
noisersup
noisersup previously approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi dismissed stale reviews from noisersup and henvic via bb43b0a January 4, 2024 16:54
@AlekSi AlekSi requested review from a team, henvic and noisersup January 4, 2024 19:59
@b1ron b1ron mentioned this pull request Jan 4, 2024
Open
@AlekSi
Copy link
Member

AlekSi commented Jan 5, 2024

@henvic @noisersup PTAL

@AlekSi AlekSi removed trust PRs that can access Actions secrets packages PRs that should build packages labels Jan 5, 2024
noisersup
noisersup approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rumyantseva rumyantseva merged commit 15c0d0c into FerretDB:main Jan 5, 2024
45 of 66 checks passed
@rumyantseva rumyantseva deleted the ismaster branch January 5, 2024 12:06
@AlekSi AlekSi added code/enhancement Some user-visible feature could work better and removed code/chore Code maintenance improvements labels Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@henvic henvic henvic approved these changes

@noisersup noisersup noisersup approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

Assignees

@rumyantseva rumyantseva

Labels
code/enhancement Some user-visible feature could work better
Projects
Current Engineering
Archived in project
Milestone
v1.18.0
Development

Successfully merging this pull request may close these issues.

Insert i/u/d documents into OpLog
4 participants
@rumyantseva @AlekSi @henvic @noisersup