Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to show maxTimeMS should not propagate to getMore for tailable cursors #3975

Closed
wants to merge 3 commits into from

Conversation

b1ron
Copy link
Contributor

@b1ron b1ron commented Jan 15, 2024

Description

Closes #2983.

It either uses the user defined value or it defaults to 1000ms. #2983 is related to non-tailable cursors over non-capped collections.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@b1ron b1ron added the do not merge PRs that should not be merged label Jan 15, 2024
@mergify mergify bot assigned b1ron Jan 15, 2024
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (21ebe3a) 73.27% compared to head (70f1371) 73.30%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3975      +/-   ##
==========================================
+ Coverage   73.27%   73.30%   +0.03%     
==========================================
  Files         329      329              
  Lines       26421    26421              
==========================================
+ Hits        19360    19368       +8     
+ Misses       5894     5888       -6     
+ Partials     1167     1165       -2     

see 2 files with indirect coverage changes

Flag Coverage Δ
filter-true 70.86% <ø> (+0.03%) ⬆️
hana-1 ?
integration 70.86% <ø> (+0.03%) ⬆️
mongodb-1 5.25% <ø> (ø)
postgresql-1 49.90% <ø> (-0.08%) ⬇️
postgresql-2 50.16% <ø> (ø)
postgresql-3 52.83% <ø> (+0.08%) ⬆️
sqlite-1 49.08% <ø> (ø)
sqlite-2 49.25% <ø> (ø)
sqlite-3 51.96% <ø> (-0.06%) ⬇️
unit 30.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@b1ron b1ron closed this by deleting the head repository May 28, 2024
@AlekSi AlekSi mentioned this pull request May 29, 2024
9 tasks
@AlekSi
Copy link
Member

AlekSi commented May 29, 2024

#4315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge PRs that should not be merged
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

Propagate maxTimeMS of find and aggregate to getMore
2 participants