Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make logger configurable in the embedded ferretdb package #4028

Merged
merged 7 commits into from Feb 22, 2024

Conversation

fadyat
Copy link
Contributor

@fadyat fadyat commented Jan 31, 2024

Description

Closes #4014.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@fadyat fadyat requested a review from a team as a code owner January 31, 2024 15:38
@mergify mergify bot assigned fadyat Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (033dfef) 76.36% compared to head (9d59293) 75.11%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4028      +/-   ##
==========================================
- Coverage   76.36%   75.11%   -1.25%     
==========================================
  Files         349      349              
  Lines       22162    22170       +8     
==========================================
- Hits        16925    16654     -271     
- Misses       3933     4250     +317     
+ Partials     1304     1266      -38     
Files Coverage Δ
internal/bson2/slog.go 87.50% <ø> (ø)
internal/util/logging/logging.go 80.00% <100.00%> (+0.33%) ⬆️
ferretdb/ferretdb.go 86.51% <86.66%> (-1.29%) ⬇️

... and 22 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 67.36% <16.66%> (-1.60%) ⬇️
hana-1 ?
integration 67.36% <16.66%> (-1.66%) ⬇️
mongodb-1 4.69% <16.66%> (-0.04%) ⬇️
mysql-1 ?
mysql-2 ?
mysql-3 ?
postgresql-1 49.04% <16.66%> (-0.16%) ⬇️
postgresql-2 48.64% <16.66%> (-0.23%) ⬇️
postgresql-3 48.76% <16.66%> (-0.10%) ⬇️
sqlite-1 48.25% <16.66%> (-0.13%) ⬇️
sqlite-2 47.94% <16.66%> (-0.09%) ⬇️
sqlite-3 47.91% <16.66%> (-0.10%) ⬇️
unit 33.16% <88.88%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup self-requested a review February 2, 2024 12:45
@noisersup noisersup added the code/chore Code maintenance improvements label Feb 2, 2024
@noisersup noisersup requested review from a team and henvic February 2, 2024 12:46
@noisersup noisersup added this to the Next milestone Feb 2, 2024
@noisersup noisersup enabled auto-merge (squash) February 2, 2024 12:46
noisersup
noisersup previously approved these changes Feb 2, 2024
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! LGTM

internal/bson2/slog.go Outdated Show resolved Hide resolved
ferretdb/ferretdb.go Show resolved Hide resolved
@AlekSi AlekSi changed the title Make logger configurable in the embedded ferretdb package Make logger configurable in the embedded ferretdb package Feb 5, 2024
@AlekSi AlekSi disabled auto-merge February 5, 2024 08:22
@AlekSi AlekSi enabled auto-merge (squash) February 5, 2024 08:22
auto-merge was automatically disabled February 5, 2024 17:04

Head branch was pushed to by a user without write access

Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 🤗

@AlekSi AlekSi removed this from the v1.20.0 milestone Feb 19, 2024
@AlekSi AlekSi added this to the Next milestone Feb 19, 2024
@noisersup noisersup enabled auto-merge (squash) February 22, 2024 09:59
@noisersup noisersup merged commit b6fd73b into FerretDB:main Feb 22, 2024
28 of 29 checks passed
henvic pushed a commit to henvic/FerretDB that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Make logger configurable in the embedded ferretdb package
4 participants