New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use bson2
package for wire queries and replies
#4108
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4108 +/- ##
==========================================
- Coverage 76.17% 75.11% -1.06%
==========================================
Files 349 349
Lines 22157 22162 +5
==========================================
- Hits 16877 16647 -230
- Misses 3966 4251 +285
+ Partials 1314 1264 -50
... and 16 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new way of using indexes to marshal/unmarshal query and reply.
Description
That would allow us to avoid extra copying in the future.
Readiness checklist
task all
, and it passed.@FerretDB/core
), Milestone (Next
), Labels, Project and project's Sprint fields.