Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bson2 package for wire queries and replies #4108

Merged
merged 1 commit into from Feb 22, 2024
Merged

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Feb 21, 2024

Description

That would allow us to avoid extra copying in the future.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Feb 21, 2024
@AlekSi AlekSi added this to the Next milestone Feb 21, 2024
@AlekSi AlekSi self-assigned this Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 69 lines in your changes are missing coverage. Please review.

Comparison is base (9de2931) 76.17% compared to head (6209c8b) 75.11%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4108      +/-   ##
==========================================
- Coverage   76.17%   75.11%   -1.06%     
==========================================
  Files         349      349              
  Lines       22157    22162       +5     
==========================================
- Hits        16877    16647     -230     
- Misses       3966     4251     +285     
+ Partials     1314     1264      -50     
Files Coverage Δ
internal/handler/common/ismaster.go 73.07% <100.00%> (-1.00%) ⬇️
internal/wire/op_msg.go 60.32% <100.00%> (-0.85%) ⬇️
internal/handler/cmd_query.go 25.00% <0.00%> (+1.19%) ⬆️
internal/wire/msg_body.go 47.56% <33.33%> (ø)
internal/wire/op_reply.go 50.00% <46.15%> (+5.55%) ⬆️
internal/wire/op_query.go 46.91% <42.42%> (+10.68%) ⬆️

... and 16 files with indirect coverage changes

Flag Coverage Δ
filter-true 67.41% <31.74%> (-0.37%) ⬇️
hana-1 ?
integration 67.41% <31.74%> (-0.37%) ⬇️
mongodb-1 4.73% <0.00%> (-0.01%) ⬇️
postgresql-1 49.14% <31.74%> (+0.93%) ⬆️
postgresql-2 48.71% <30.95%> (+0.98%) ⬆️
postgresql-3 48.79% <31.74%> (+0.88%) ⬆️
sqlite-1 48.24% <31.74%> (+0.86%) ⬆️
sqlite-2 47.91% <30.95%> (+0.88%) ⬆️
sqlite-3 47.96% <31.74%> (+0.89%) ⬆️
unit 33.14% <42.06%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review February 21, 2024 18:09
@AlekSi AlekSi requested a review from a team as a code owner February 21, 2024 18:09
@AlekSi AlekSi enabled auto-merge (squash) February 21, 2024 18:09
@AlekSi AlekSi requested review from a team, henvic and noisersup February 21, 2024 18:09
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new way of using indexes to marshal/unmarshal query and reply.

@AlekSi AlekSi merged commit 033dfef into FerretDB:main Feb 22, 2024
28 of 33 checks passed
@AlekSi AlekSi deleted the wire branch February 22, 2024 01:23
henvic pushed a commit to henvic/FerretDB that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants