New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace bson
with bson2
in wire
#4110
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4110 +/- ##
==========================================
- Coverage 74.62% 74.25% -0.37%
==========================================
Files 352 352
Lines 22579 22579
==========================================
- Hits 16849 16767 -82
- Misses 4436 4553 +117
+ Partials 1294 1259 -35
... and 20 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't miss that one
Some tests related to NaN need to be adjusted, otherwise looks good to me |
There is no need to merge main and waste CI cycles: tests should be fixed first |
Description
Only
bson2
tests still use oldbson
package.Readiness checklist
task all
, and it passed.@FerretDB/core
), Milestone (Next
), Labels, Project and project's Sprint fields.