Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace bson with bson2 in wire #4110

Merged
merged 23 commits into from Feb 28, 2024
Merged

Replace bson with bson2 in wire #4110

merged 23 commits into from Feb 28, 2024

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Feb 22, 2024

Description

Only bson2 tests still use old bson package.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned AlekSi Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 67.54386% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 74.25%. Comparing base (910c351) to head (1aaca4f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4110      +/-   ##
==========================================
- Coverage   74.62%   74.25%   -0.37%     
==========================================
  Files         352      352              
  Lines       22579    22579              
==========================================
- Hits        16849    16767      -82     
- Misses       4436     4553     +117     
+ Partials     1294     1259      -35     
Files Coverage Δ
internal/bson2/bson2.go 84.37% <100.00%> (+0.24%) ⬆️
internal/bson2/decode.go 93.84% <ø> (+2.80%) ⬆️
internal/bson2/document.go 51.47% <ø> (+0.76%) ⬆️
internal/bson2/encode.go 58.53% <ø> (+1.39%) ⬆️
internal/bson2/raw_document.go 83.56% <100.00%> (ø)
internal/handler/handlererrors/error.go 84.61% <ø> (ø)
internal/wire/msg_body.go 50.00% <ø> (+2.43%) ⬆️
internal/wire/op_query.go 49.38% <33.33%> (+2.46%) ⬆️
internal/wire/op_reply.go 53.22% <60.00%> (+3.22%) ⬆️
internal/wire/op_msg.go 69.84% <69.47%> (+9.51%) ⬆️

... and 20 files with indirect coverage changes

Flag Coverage Δ
filter-true 67.65% <48.24%> (+0.43%) ⬆️
hana-1 ?
integration 67.65% <48.24%> (+0.43%) ⬆️
mongodb-1 4.76% <0.00%> (+0.12%) ⬆️
postgresql-1 48.47% <47.36%> (+0.65%) ⬆️
postgresql-2 48.84% <47.36%> (+0.44%) ⬆️
postgresql-3 49.34% <48.24%> (+0.53%) ⬆️
sqlite-1 47.61% <47.36%> (+0.52%) ⬆️
sqlite-2 48.03% <47.36%> (+0.47%) ⬆️
sqlite-3 48.48% <48.24%> (+0.57%) ⬆️
unit 32.76% <65.78%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't miss that one

@AlekSi AlekSi added this to the Next milestone Feb 23, 2024
@AlekSi AlekSi added the code/chore Code maintenance improvements label Feb 23, 2024
@AlekSi AlekSi marked this pull request as ready for review February 23, 2024 05:45
@AlekSi AlekSi requested a review from a team as a code owner February 23, 2024 05:45
@AlekSi AlekSi enabled auto-merge (squash) February 23, 2024 05:45
@AlekSi AlekSi requested review from a team, henvic and noisersup February 23, 2024 05:45
rumyantseva
rumyantseva previously approved these changes Feb 23, 2024
noisersup
noisersup previously approved these changes Feb 23, 2024
@noisersup
Copy link
Member

Some tests related to NaN need to be adjusted, otherwise looks good to me

chilagrow
chilagrow previously approved these changes Feb 26, 2024
@AlekSi
Copy link
Member Author

AlekSi commented Feb 28, 2024

There is no need to merge main and waste CI cycles: tests should be fixed first

@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Feb 28, 2024
@AlekSi AlekSi dismissed stale reviews from noisersup and chilagrow via 0b91e2d February 28, 2024 08:45
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Feb 28, 2024
@AlekSi AlekSi disabled auto-merge February 28, 2024 12:26
@AlekSi AlekSi merged commit a8cfbb5 into FerretDB:main Feb 28, 2024
31 checks passed
@AlekSi AlekSi deleted the endless-wire branch February 28, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants