Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix env-data #4289

Merged
merged 7 commits into from
May 24, 2024
Merged

Fix env-data #4289

merged 7 commits into from
May 24, 2024

Conversation

chilagrow
Copy link
Contributor

@chilagrow chilagrow commented May 21, 2024

Description

task env-data does not populate database like it should, because env-data was not run on ferretdb postgresql database. It was using temporary test database that exists duration of the test.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/chore Code maintenance improvements label May 21, 2024
@chilagrow chilagrow self-assigned this May 21, 2024
@chilagrow chilagrow requested a review from a team as a code owner May 21, 2024 06:12
@chilagrow chilagrow changed the title Fix envData Fix env-data May 21, 2024
@chilagrow chilagrow marked this pull request as draft May 21, 2024 06:15
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.14%. Comparing base (76f7664) to head (2ac7eae).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4289      +/-   ##
==========================================
- Coverage   74.90%   74.14%   -0.77%     
==========================================
  Files         323      323              
  Lines       22365    22365              
==========================================
- Hits        16752    16582     -170     
- Misses       4385     4573     +188     
+ Partials     1228     1210      -18     
Files Coverage Δ
integration/setup/listener.go 71.14% <100.00%> (-4.03%) ⬇️
integration/setup/setup.go 84.91% <100.00%> (ø)
integration/setup/setup_compat.go 87.50% <100.00%> (-2.28%) ⬇️

... and 14 files with indirect coverage changes

Flag Coverage Δ
filter-true 67.42% <100.00%> (-0.85%) ⬇️
hana-1 ?
integration 67.42% <100.00%> (-0.85%) ⬇️
mongodb-1 5.15% <0.00%> (+<0.01%) ⬆️
postgresql-1 44.73% <80.00%> (-0.04%) ⬇️
postgresql-2 44.86% <80.00%> (-0.02%) ⬇️
postgresql-3 41.52% <80.00%> (-0.04%) ⬇️
postgresql-4 41.16% <80.00%> (+<0.01%) ⬆️
postgresql-5 43.35% <80.00%> (+<0.01%) ⬆️
sqlite-1 43.77% <80.00%> (+0.04%) ⬆️
sqlite-2 44.17% <80.00%> (-0.02%) ⬇️
sqlite-3 40.77% <80.00%> (ø)
sqlite-4 40.53% <80.00%> (+0.02%) ⬆️
sqlite-5 42.47% <80.00%> (ø)
unit 33.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow added this to the v1.22.0 milestone May 21, 2024
@chilagrow chilagrow marked this pull request as ready for review May 21, 2024 06:43
@chilagrow chilagrow enabled auto-merge (squash) May 21, 2024 06:43
@rumyantseva rumyantseva requested review from a team and noisersup May 22, 2024 10:59
rumyantseva
rumyantseva previously approved these changes May 22, 2024
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chilagrow chilagrow merged commit 0811dd7 into FerretDB:main May 24, 2024
33 checks passed
chilagrow added a commit to chilagrow/FerretDB that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants