-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix env-data
#4289
Merged
Merged
Fix env-data
#4289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4289 +/- ##
==========================================
- Coverage 74.90% 74.14% -0.77%
==========================================
Files 323 323
Lines 22365 22365
==========================================
- Hits 16752 16582 -170
- Misses 4385 4573 +188
+ Partials 1228 1210 -18
... and 14 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
rumyantseva
reviewed
May 21, 2024
rumyantseva
previously approved these changes
May 22, 2024
rumyantseva
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
noisersup
approved these changes
May 24, 2024
chilagrow
added a commit
to chilagrow/FerretDB
that referenced
this pull request
May 30, 2024
This reverts commit 0811dd7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
task env-data
does not populate database like it should, becauseenv-data
was not run onferretdb
postgresql database. It was using temporary test database that exists duration of the test.Readiness checklist
task all
, and it passed.@FerretDB/core
), Milestone (Next
), Labels, Project and project's Sprint fields.