Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update guidelines #496

Merged
merged 33 commits into from
Apr 25, 2022
Merged

Update guidelines #496

merged 33 commits into from
Apr 25, 2022

Conversation

seeforschauer
Copy link
Contributor

@seeforschauer seeforschauer commented Apr 20, 2022 •
edited by AlekSi

No description provided.

@codecov
Copy link

codecov bot commented Apr 20, 2022 •
edited

Codecov Report

Merging #496 (e8c294f) into main (2cbd7a4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #496   +/-   ##
=======================================
  Coverage   62.86%   62.86%           
=======================================
  Files         118      118           
  Lines        6522     6522           
=======================================
  Hits         4100     4100           
  Misses       1873     1873           
  Partials      549      549
Flag Coverage Δ
FerretDB 47.97% <ø> (ø)
MongoDB 6.24% <ø> (ø)
integration 48.00% <ø> (ø)
unit 43.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@seeforschauer seeforschauer marked this pull request as ready for review April 20, 2022 06:51
AlekSi
AlekSi reviewed Apr 20, 2022
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

task docs-fmt

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
AlekSi
AlekSi reviewed Apr 20, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
w84thesun
w84thesun reviewed Apr 20, 2022
View reviewed changes
.github/PROCESS.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
seeforschauer and others added 2 commits April 20, 2022 12:07
@seeforschauer
Update CONTRIBUTING.md
f2badbc 
Co-authored-by: Dmitry <dmitry.eremenko@ferretdb.io>
@seeforschauer
Update .github/PROCESS.md
f1a864d 
Co-authored-by: Dmitry <dmitry.eremenko@ferretdb.io>
@seeforschauer
Copy link
Contributor Author

fixed, thank you.

w84thesun
w84thesun previously approved these changes Apr 20, 2022
View reviewed changes
AlekSi
AlekSi reviewed Apr 20, 2022
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, let's document task fmt and task lint targets, move most of the rest to the future blog post, and replace instructions for editors by links

@seeforschauer
Copy link
Contributor Author

@AlekSi @w84thesun PTAL

AlekSi
AlekSi reviewed Apr 25, 2022
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title (edit: and description) are outdated now

.github/PROCESS.md Outdated Show resolved Hide resolved
.github/PROCESS.md Outdated Show resolved Hide resolved
.github/PROCESS.md Outdated Show resolved Hide resolved
.github/PROCESS.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@AlekSi AlekSi modified the milestones: v0.3.0, v0.2.0 Apr 25, 2022
@seeforschauer seeforschauer changed the title Add IDE setup guide for Visual Studio Code and Goland Update guidelines in processes and with task fmt Apr 25, 2022
@AlekSi AlekSi changed the title Update guidelines in processes and with task fmt Update guidelines Apr 25, 2022
@AlekSi AlekSi added the project Project maintenance label Apr 25, 2022
@AlekSi AlekSi merged commit 9377517 into FerretDB:main Apr 25, 2022
@seeforschauer seeforschauer deleted the ide-setup branch May 3, 2022 12:48
@AlekSi AlekSi added the documentation Something user-visible is badly or not documented label May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@w84thesun w84thesun Awaiting requested review from w84thesun

Assignees

@seeforschauer seeforschauer

Labels
documentation Something user-visible is badly or not documented project Project maintenance
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seeforschauer @AlekSi @w84thesun