Update CONTRIBUTING.md with typo fix and a tiny correction #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rumyantseva
added
the
documentation
AlekSi
approved these changes
May 9, 2022
|
I only disagree that this PR is opinionated: the text was factually incorrect :) |
Codecov Report
@@ Coverage Diff @@
## main #574 +/- ##
=======================================
Coverage 61.03% 61.03%
=======================================
Files 121 121
Lines 6650 6650
=======================================
Hits 4059 4059
Misses 2081 2081
Partials 510 510
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original purpose of this change was to correct a typo.
Though, after re-reading the text, I believe it's better to call
cmddirectory, not package. All the packages insidecmdare calledmain;)It could be a bit opinionated, so feel free to reject if you disagree.