Rename OP_* constants to OpCode* constants
#620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #620 +/- ##
=======================================
Coverage 63.28% 63.28%
=======================================
Files 122 122
Lines 7157 7157
=======================================
Hits 4529 4529
Misses 2081 2081
Partials 547 547
Flags with carried forward coverage won't be shown. Click here to find out more. |
seeforschauer
requested review from
a team and
w84thesun
and removed request for
a team
w84thesun
previously approved these changes
May 20, 2022
AlekSi
requested changes
May 20, 2022
internal/wire/msg_header.go
Outdated
| OP_KILL_CURSORS = OpCode(2007) // OP_KILL_CURSORS | ||
| OP_COMPRESSED = OpCode(2012) // OP_COMPRESSED | ||
| OP_MSG = OpCode(2013) // OP_MSG | ||
| OpCodeReply = OpCode(1) // OpCodeReply |
There was a problem hiding this comment.
We should not change string representations – they follow protocol spec
seeforschauer
commented
May 20, 2022
AlekSi
requested review from
a team and
rumyantseva
and removed request for
a team
Co-authored-by: Elena Grahovac <elena@grahovac.me>
rumyantseva
previously approved these changes
May 23, 2022
|
codecov/patch check is not required for that reason |
AlekSi
requested changes
May 23, 2022
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
AlekSi
requested changes
May 24, 2022
internal/wire/msg_header.go
Outdated
| OP_KILL_CURSORS = OpCode(2007) // OP_KILL_CURSORS | ||
| OP_COMPRESSED = OpCode(2012) // OP_COMPRESSED | ||
| OP_MSG = OpCode(2013) // OP_MSG | ||
| // OpCodeReply is deprecated. |
There was a problem hiding this comment.
We use it, so it should have a better description
internal/wire/msg_header.go
Outdated
| // OpCodeGetByOID is deprecated. | ||
| OpCodeGetByOID = OpCode(2003) // OP_GET_BY_OID | ||
|
|
||
| // OpCodeQuery is deprecated. |
There was a problem hiding this comment.
We use it, so it should have a better description
|
added some comments, however, I acknowledge that it may differ how I understand the purpose from understanding of others. |
w84thesun
approved these changes
May 26, 2022
AlekSi
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.