Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle both buildinfo and buildInfo commands #688

Merged
merged 3 commits into from
Jun 2, 2022
Merged

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jun 2, 2022

The former is sent by the old mongo shell.

The former is sent by the old `mongo` shell.
@AlekSi AlekSi added the code/bug Some user-visible feature works incorrectly label Jun 2, 2022
@AlekSi AlekSi added this to the v0.3.1 milestone Jun 2, 2022
@AlekSi AlekSi self-assigned this Jun 2, 2022
@AlekSi AlekSi requested a review from rumyantseva as a code owner June 2, 2022 14:42
@AlekSi AlekSi requested review from a team, w84thesun and seeforschauer and removed request for a team June 2, 2022 14:42
@AlekSi AlekSi enabled auto-merge (squash) June 2, 2022 14:42
@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #688 (e365e06) into main (a8751f4) will increase coverage by 0.30%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
+ Coverage   63.16%   63.46%   +0.30%     
==========================================
  Files         191      191              
  Lines        7625     7625              
==========================================
+ Hits         4816     4839      +23     
+ Misses       2248     2224      -24     
- Partials      561      562       +1     
Impacted Files Coverage Δ
internal/handlers/common/msg_listcommands.go 85.71% <ø> (ø)
internal/handlers/common/msg_buildinfo.go 87.50% <0.00%> (+87.50%) ⬆️
internal/handlers/pg/msg_buildinfo.go 100.00% <0.00%> (+100.00%) ⬆️
Flag Coverage Δ
FerretDB 59.13% <ø> (+0.30%) ⬆️
MongoDB 6.31% <ø> (ø)
integration 59.16% <ø> (+0.30%) ⬆️
unit 23.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi changed the title Handle both buildinfo and buildInfo Handle both buildinfo and buildInfo commands Jun 2, 2022
@AlekSi AlekSi disabled auto-merge June 2, 2022 14:50
@AlekSi AlekSi enabled auto-merge (squash) June 2, 2022 14:50
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit d2328eb into FerretDB:main Jun 2, 2022
@AlekSi AlekSi deleted the buildinfo branch June 2, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/bug Some user-visible feature works incorrectly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants