Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement setFreeMonitoring stub #759

Merged
merged 6 commits into from
Jun 23, 2022
Merged

Implement setFreeMonitoring stub #759

merged 6 commits into from
Jun 23, 2022

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Jun 21, 2022

Closes #744.

Checklist

  • Tests are added for new functionality or fixed bugs.
  • task all passes.

See CONTRIBUTING.md for more details.

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #759 (07ff3e8) into main (9e28a0a) will increase coverage by 0.04%.
The diff coverage is 67.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #759      +/-   ##
==========================================
+ Coverage   65.31%   65.35%   +0.04%     
==========================================
  Files         207      211       +4     
  Lines        8447     8478      +31     
==========================================
+ Hits         5517     5541      +24     
- Misses       2287     2293       +6     
- Partials      643      644       +1     
Impacted Files Coverage Δ
internal/handlers/common/error.go 82.65% <ø> (ø)
internal/handlers/common/errorcode_string.go 80.00% <ø> (ø)
internal/handlers/common/msg_listcommands.go 85.71% <ø> (ø)
internal/handlers/dummy/msg_setfreemonitoring.go 0.00% <0.00%> (ø)
internal/handlers/tigris/msg_setfreemonitoring.go 0.00% <0.00%> (ø)
internal/handlers/common/msg_setfreemonitoring.go 76.00% <76.00%> (ø)
internal/handlers/pg/msg_setfreemonitoring.go 100.00% <100.00%> (ø)
internal/handlers/pg/msg_dbstats.go 72.09% <0.00%> (+6.97%) ⬆️
Flag Coverage Δ
FerretDB 62.67% <77.77%> (+0.09%) ⬆️
MongoDB 7.22% <0.00%> (-0.03%) ⬇️
integration 62.77% <77.77%> (+0.08%) ⬆️
unit 25.51% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup linked an issue Jun 21, 2022 that may be closed by this pull request
@noisersup noisersup changed the title Implement setFreeMonitoringStatus stub Implement setFreeMonitoring stub Jun 22, 2022
@noisersup noisersup self-assigned this Jun 22, 2022
@noisersup noisersup marked this pull request as ready for review June 22, 2022 17:46
@AlekSi AlekSi requested review from a team and seeforschauer and removed request for a team June 22, 2022 18:08
integration/commands_freemonitoring_test.go Outdated Show resolved Hide resolved
integration/commands_freemonitoring_test.go Outdated Show resolved Hide resolved
internal/handlers/common/msg_setfreemonitoring.go Outdated Show resolved Hide resolved
@AlekSi AlekSi added the code/feature Some user-visible feature is not implemented yet label Jun 22, 2022
@AlekSi AlekSi enabled auto-merge (squash) June 22, 2022 19:20
@noisersup noisersup requested a review from AlekSi June 22, 2022 20:18
@AlekSi
Copy link
Member

AlekSi commented Jun 23, 2022

@rumyantseva @seeforschauer PTAL

@AlekSi AlekSi merged commit 43e6bf2 into FerretDB:main Jun 23, 2022
@noisersup noisersup deleted the issue-744 branch June 23, 2022 11:07
@AlekSi AlekSi added this to the v0.3.1 milestone Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/feature Some user-visible feature is not implemented yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement setFreeMonitoring command (stub)
3 participants