Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Tigris databases #842

Merged
merged 2 commits into from
Jul 4, 2022
Merged

Create Tigris databases #842

merged 2 commits into from
Jul 4, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 4, 2022

Refs #782.

@AlekSi AlekSi self-assigned this Jul 4, 2022
@AlekSi AlekSi added the code/chore Code maintenance improvements label Jul 4, 2022
@AlekSi AlekSi added this to the v0.5.0 milestone Jul 4, 2022
@codecov
Copy link

codecov bot commented Jul 4, 2022 •
edited
Loading

Codecov Report

Merging #842 (504e340) into main (6d9a821) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #842   +/-   ##
=======================================
  Coverage   59.08%   59.08%           
=======================================
  Files         217      217           
  Lines        9817     9817           
=======================================
  Hits         5800     5800           
  Misses       3306     3306           
  Partials      711      711
Impacted Files Coverage Δ
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
internal/handlers/pg/pgdb/pool.go 57.97% <0.00%> (+0.58%) ⬆️
Flag Coverage Δ
FerretDB 61.29% <ø> (-0.04%) ⬇️
MongoDB 7.23% <ø> (-0.04%) ⬇️
integration 61.39% <ø> (-0.04%) ⬇️
unit 27.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review July 4, 2022 19:21
@AlekSi AlekSi requested review from a team, w84thesun, seeforschauer, noisersup and rumyantseva and removed request for a team July 4, 2022 19:21
@AlekSi AlekSi enabled auto-merge (squash) July 4, 2022 19:22
rumyantseva
rumyantseva approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of minor (non-blocking) concerns, see the comments.
In general, LGTM.

cmd/envtool/main.go Show resolved Hide resolved
cmd/envtool/main.go Show resolved Hide resolved
@AlekSi AlekSi disabled auto-merge July 4, 2022 19:41
@AlekSi AlekSi merged commit 61c8e92 into FerretDB:main Jul 4, 2022
@AlekSi AlekSi deleted the envtool branch July 4, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun Awaiting requested review from w84thesun w84thesun was automatically assigned from FerretDB/core

@seeforschauer seeforschauer Awaiting requested review from seeforschauer seeforschauer was automatically assigned from FerretDB/core

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlekSi @rumyantseva